Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudrunv2 and dialogflowcx #11132

Merged
merged 3 commits into from
Jul 10, 2024
Merged

cloudrunv2 and dialogflowcx #11132

merged 3 commits into from
Jul 10, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Jul 10, 2024

please view by commit

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 32 deletions(-))
google-beta provider: Diff ( 8 files changed, 32 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 29
Passed tests: 29
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dialogflowcx

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@c2thorn c2thorn requested a review from zli82016 July 10, 2024 17:27
zli82016
zli82016 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c2thorn c2thorn merged commit aea5962 into GoogleCloudPlatform:main Jul 10, 2024
14 checks passed
@c2thorn c2thorn deleted the go-rewrite-services branch July 10, 2024 18:51
This was referenced Jul 10, 2024
Merged
Merged
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
@c2thorn @pcostell
cloudrunv2 and dialogflowcx (GoogleCloudPlatform#11132)
7da7100
vijaykanthm pushed a commit to vijaykanthm/magic-modules that referenced this pull request Jul 22, 2024
@c2thorn @vijaykanthm
cloudrunv2 and dialogflowcx (GoogleCloudPlatform#11132)
ab3597d
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Aug 1, 2024
@c2thorn
cloudrunv2 and dialogflowcx (GoogleCloudPlatform#11132)
859dd52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zli82016 zli82016 zli82016 approved these changes

Assignees
No one assigned
Labels
service/dialogflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c2thorn @modular-magician @zli82016