Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace labelKeys/Values for tagKeys/Values in policy constraint examples #11125

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

rubensf
Copy link
Contributor

@rubensf rubensf commented Jul 9, 2024

GCP does not support labels as iam or org policy constraints. This is documented in multiple locations, such as https://cloud.google.com/compute/docs/labeling-resources#labels_and_tags.

Release Note Template for Downstream PRs (will be copied)


GCP does not support labels as iam or org policy constraints. This is documented in multiple locations, such as
https://cloud.google.com/compute/docs/labeling-resources#labels_and_tags.
Copy link

github-actions bot commented Jul 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/orgpolicy and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 9, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants