Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity v6.0.0 feature branch testing #11104

Merged
merged 11 commits into from
Jul 10, 2024

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Jul 3, 2024

This PR enables nightly testing of the v6.0.0 feature branch

Schedule:

  • On Saturday-Wednesday nightly tests will run off main branch of google and google-beta repos as ususal.
  • On Thursdays the GA tests will run off the feature branch. Beta tests are off main as usual.
  • On Fridays the Beta tests will run off the feature branch. GA tests are off main as usual.

What it looks like:

  • There's a new project put inside the root "Google Cloud" project called "6.0.0 Major Release Testing"
  • Inside there is a Google and Google Beta project, which each contain Nightly Test projects
  • Those Nightly Test projects contain builds for all packages

Here is an example deployment: https://hashicorp.teamcity.com/project/TerraformProviders_SarahSTestProjectTpg?projectTab=overview&mode=builds

Screenshots of project layout :

Screenshot 2024-07-03 at 16 47 50

Screenshots of the Beta cron triggers:

  1. main branch
Screenshot 2024-07-03 at 16 54 55
  1. FEATURE-BRANCH-major-release-6.0.0 branch
Screenshot 2024-07-03 at 16 54 24

Release Note Template for Downstream PRs (will be copied)


@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 136 insertions(+), 30 deletions(-))

@SarahFrench SarahFrench requested a review from shuyama1 July 3, 2024 16:39
@SarahFrench SarahFrench marked this pull request as ready for review July 3, 2024 16:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 136 insertions(+), 30 deletions(-))

Copy link

github-actions bot commented Jul 8, 2024

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I only have some small questions. Thank you so much for the work!

Also would you mind granting me access to https://hashicorp.teamcity.com/project/TerraformProviders_SarahSTestProjectTpg?projectTab=overview&mode=builds?

@SarahFrench
Copy link
Contributor Author

@shuyama1 Thanks for the review- I've given you access to the project!

@SarahFrench
Copy link
Contributor Author

Actually I've found an issue with the config - something is wrong with how the v6.0 testing project accesses GitHub branches 🤦 - marking as draft while I look into it

@SarahFrench SarahFrench marked this pull request as draft July 8, 2024 19:30
@SarahFrench SarahFrench marked this pull request as ready for review July 8, 2024 22:27
@SarahFrench
Copy link
Contributor Author

I think that's fixed - you should have access to https://hashicorp.teamcity.com/project/TerraformProviders_SarahSTestProject?projectTab=overview&mode=builds

@SarahFrench
Copy link
Contributor Author

I'll save merging this until Wednesday, to avoid any potential disruption to cutting a new release

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 145 insertions(+), 30 deletions(-))

@SarahFrench SarahFrench requested a review from shuyama1 July 9, 2024 18:54
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The TeamCity testing setup looks good as well. Thank you so much!

@SarahFrench
Copy link
Contributor Author

Thanks! I'll follow this up with a separate PR that documents how we can add feature branch testing for v7.0+

And I'll merge this PR tomorrow once the nightlies complete

@shuyama1
Copy link
Member

shuyama1 commented Jul 9, 2024

Thanks! I'll follow this up with a separate PR that documents how we can add feature branch testing for v7.0+

And I'll merge this PR tomorrow once the nightlies complete

Sounds good. Thank you, Sarah!

@SarahFrench SarahFrench merged commit 2f6cbf5 into GoogleCloudPlatform:main Jul 10, 2024
12 checks passed
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
vijaykanthm pushed a commit to vijaykanthm/magic-modules that referenced this pull request Jul 22, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants