-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TeamCity v6.0.0 feature branch testing #11104
TeamCity v6.0.0 feature branch testing #11104
Conversation
…overwriting some fields
…en the acc test builds are triggered
… week, differing for GA vs Beta
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
...rraform/.teamcity/components/projects/feature_branches/FEATURE-BRANCH-major-release-6.0.0.kt
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. I only have some small questions. Thank you so much for the work!
Also would you mind granting me access to https://hashicorp.teamcity.com/project/TerraformProviders_SarahSTestProjectTpg?projectTab=overview&mode=builds?
mmv1/third_party/terraform/.teamcity/components/projects/reused/mm_upstream.kt
Show resolved
Hide resolved
mmv1/third_party/terraform/.teamcity/components/builds/build_triggers.kt
Show resolved
Hide resolved
@shuyama1 Thanks for the review- I've given you access to the project! |
Actually I've found an issue with the config - something is wrong with how the v6.0 testing project accesses GitHub branches 🤦 - marking as draft while I look into it |
I think that's fixed - you should have access to https://hashicorp.teamcity.com/project/TerraformProviders_SarahSTestProject?projectTab=overview&mode=builds |
I'll save merging this until Wednesday, to avoid any potential disruption to cutting a new release |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The TeamCity testing setup looks good as well. Thank you so much!
Thanks! I'll follow this up with a separate PR that documents how we can add feature branch testing for v7.0+ And I'll merge this PR tomorrow once the nightlies complete |
Sounds good. Thank you, Sarah! |
This PR enables nightly testing of the v6.0.0 feature branch
Schedule:
google
andgoogle-beta
repos as ususal.What it looks like:
Here is an example deployment: https://hashicorp.teamcity.com/project/TerraformProviders_SarahSTestProjectTpg?projectTab=overview&mode=builds
Screenshots of project layout :
Screenshots of the Beta cron triggers:
Release Note Template for Downstream PRs (will be copied)