Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router peer changes- Added customLearnedIpRanges and customLearnedRoutePriority #11118

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

kalpanda
Copy link
Contributor

@kalpanda kalpanda commented Jul 8, 2024

Added customLearnedIpRanges and customLearnedRoutePriority as well as an update test for both to RouterPeer

compute: added `custom_learned_ip_ranges` and `custom_learned_route_priority` fields to `google_compute_router_peer` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 8, 2024
@kalpanda kalpanda marked this pull request as ready for review July 10, 2024 06:15
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge July 10, 2024 06:15
@modular-magician modular-magician added service/compute-router and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 123 insertions(+))
google-beta provider: Diff ( 2 files changed, 123 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 966
Passed tests: 885
Skipped tests: 73
Affected tests: 8

Click here to see the affected service packages
  • compute

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeRouterPeer_EnableDisableIpv6
  • TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
  • TestAccComputeRouterPeer_UpdateIpv6Address
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeRouterPeer_advertiseMode
  • TestAccComputeRouterPeer_bfd
  • TestAccComputeRouterPeer_enable

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRouterPeer_EnableDisableIpv6[Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate[Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address[Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey[Debug log]
TestAccComputeRouterPeer_advertiseMode[Debug log]
TestAccComputeRouterPeer_bfd[Debug log]
TestAccComputeRouterPeer_enable[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants