Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: datastream sql server connection profile/stream from beta to GA #11159

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

maor-mordehay
Copy link
Contributor

@maor-mordehay maor-mordehay commented Jul 15, 2024

Change Datastream SQL Server resources to GA

datastream: promoted `sql_server_profile` field in `google_datastream_connection_profile` resource from beta to GA
datastream: promoted `source_config.sql_server_source_config` and `backfill_all.sql_server_excluded_objects` fields in `google_datastream_stream` resource from beta to GA

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from zli82016 July 15, 2024 12:15
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/datastream and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 15, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2427 insertions(+), 772 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 13 deletions(-))

@zli82016
Copy link
Member

Modified the release notes.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants