Remove default addition of IAP message in encoder and decoder, add new required `enabled` field and remove the previous required tags under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service #9581

arnabadg-google · 2023-12-05T00:03:38Z

Fixes internal issue b/310147789
fixes hashicorp/terraform-provider-google#17494
fixes hashicorp/terraform-provider-google#16585

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue regarding sending `enabled` field by default for null `iap` message in `google_compute_backend_service` and `google_compute_region_backend_service`

compute: Add new required field `enabled` in `google_compute_backend_service` and `google_compute_region_backend_service`

modular-magician · 2023-12-05T00:04:48Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-12-05T00:13:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician · 2023-12-05T01:26:13Z

Tests analytics

Total tests: 3261
Passed tests 2852
Skipped tests: 332
Affected tests: 77

Action taken

Found 77 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionUrlMap_ilbRouteUpdate|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample|TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample|TestAccComputeRegionBackendService_regionBackendServiceExternalExample|TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample|TestAccComputeRegionBackendService_regionBackendServiceCacheExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRegionUrlMap_noPathRulesWithUpdate|TestAccComputeRegionUrlMap_advanced|TestAccComputeRegionUrlMap_update_path_matcher|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample|TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample|TestAccComputeRegionUrlMap_regionUrlMapBasicExample|TestAccComputeRegionTargetTcpProxy_update|TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample|TestAccComputeRegionTargetHttpsProxy_update|TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample|TestAccComputeRegionTargetHttpProxy_update|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeRegionBackendService_ilbUpdateBasic|TestAccComputeRegionBackendService_withSecurityPolicy|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRegionUrlMap_defaultRouteAction_full_update|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccDNSRecordSet_routingPolicy|TestAccIapWebRegionBackendServiceIamPolicyGenerated_withCondition|TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition|TestAccIapWebRegionBackendServiceIamPolicyGenerated|TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition|TestAccIapWebRegionBackendServiceIamMemberGenerated|TestAccIapWebRegionBackendServiceIamBindingGenerated

Get to know how VCR tests work

modular-magician · 2023-12-05T03:26:47Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log]
TestAccComputeRoute_routeIlbExample[Error message] [Debug log]
TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log]
TestAccComputeRegionBackendService_basic[Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log]
TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamBindingGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-05T17:55:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician · 2023-12-05T19:08:37Z

Tests analytics

Total tests: 3262
Passed tests 2891
Skipped tests: 332
Affected tests: 39

Action taken

Found 39 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccDNSRecordSet_routingPolicy|TestAccIapWebRegionBackendServiceIamBindingGenerated|TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition|TestAccIapWebRegionBackendServiceIamMemberGenerated|TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition|TestAccIapWebRegionBackendServiceIamPolicyGenerated_withCondition|TestAccIapWebRegionBackendServiceIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-12-05T19:49:36Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log]
TestAccComputeRegionBackendService_basic[Error message] [Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log]
TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log]
TestAccComputeRoute_routeIlbExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccIapWebRegionBackendServiceIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-27T05:01:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician · 2023-12-27T05:19:23Z

Tests analytics

Total tests: 857
Passed tests 760
Skipped tests: 65
Affected tests: 32

Click here to see the affected service packages

compute

Action taken

Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRoute_routeIlbExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate

Get to know how VCR tests work

modular-magician · 2023-12-27T19:07:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician · 2023-12-27T19:25:12Z

Tests analytics

Total tests: 857
Passed tests 760
Skipped tests: 65
Affected tests: 32

Click here to see the affected service packages

compute

Action taken

Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample

Get to know how VCR tests work

shuyama1 · 2023-12-28T17:07:45Z

VCR issue should be fixed by #9722.

/gcbrun

modular-magician · 2023-12-28T17:17:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician · 2023-12-28T17:21:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

shuyama1 · 2023-12-28T17:23:30Z

/gcbrun

modular-magician · 2023-12-28T17:34:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician · 2023-12-28T17:53:14Z

Tests analytics

Total tests: 858
Passed tests 761
Skipped tests: 65
Affected tests: 32

Click here to see the affected service packages

compute

Action taken

Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_basic|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-12-28T17:59:48Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log]
TestAccComputeRoute_routeIlbExample[Error message] [Debug log]
TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log]
TestAccComputeRegionBackendService_basic[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-29T06:03:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician · 2023-12-29T06:22:28Z

Tests analytics

Total tests: 858
Passed tests 761
Skipped tests: 65
Affected tests: 32

Click here to see the affected service packages

compute

Action taken

Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample

Get to know how VCR tests work

modular-magician · 2023-12-29T06:30:13Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log]
TestAccComputeRegionBackendService_basic[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeRoute_routeIlbExample[Error message] [Debug log]
TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-01-16T17:37:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

arnabadg-google · 2024-07-10T21:02:15Z

The primary breaking change here is the new required field enabled. This is breaking because user's will have to update their configs with this field if they use the parent iap.

Can you follow the instructions in https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/#make-the-change-on-feature-branch-major-release-600 to make the upgrade guide entry? Also can we add an additional breaking-change type in the changelog that specifically mentions the new required field

Done

modular-magician · 2024-07-10T21:55:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 95 insertions(+), 83 deletions(-))
google-beta provider: Diff ( 9 files changed, 96 insertions(+), 84 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 22 insertions(+), 35 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

modular-magician · 2024-07-10T22:12:44Z

Tests analytics

Total tests: 966
Passed tests: 892
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

modular-magician · 2024-07-10T22:42:45Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

c2thorn

Added a minor suggestion in the upgrade guide.

Generally, we try to make forward-compatible changes in the main branch to make the transition easier for users. In this case, it would mean adding enabled as an optional field to the main branch ahead of time so users can add it to their configs successfully before migrating to 6.0. However, with the logic in the decoders, would this be too complicated to do in main?

mmv1/third_party/terraform/website/docs/guides/version_6_upgrade.html.markdown

arnabadg-google · 2024-07-17T17:10:55Z

Added a minor suggestion in the upgrade guide.

Generally, we try to make forward-compatible changes in the main branch to make the transition easier for users. In this case, it would mean adding enabled as an optional field to the main branch ahead of time so users can add it to their configs successfully before migrating to 6.0. However, with the logic in the decoders, would this be too complicated to do in main?

As discussed offline, there is no point of just adding the enabled field in the main branch. The main point of the PR is to remove the code block from the encoder and decoder which is a breaking change and needs major release. So keeping the PR as it is.

modular-magician · 2024-07-17T17:18:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 95 insertions(+), 83 deletions(-))
google-beta provider: Diff ( 9 files changed, 96 insertions(+), 84 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 22 insertions(+), 35 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

modular-magician · 2024-07-17T17:34:32Z

Tests analytics

Total tests: 966
Passed tests: 823
Skipped tests: 73
Affected tests: 70

Click here to see the affected service packages

compute

Action taken

Found 70 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeBackendService_trafficDirectorUpdateBasic

TestAccComputeBackendService_trafficDirectorUpdateFull

TestAccComputeBackendService_trafficDirectorUpdateLbPolicies

TestAccComputeForwardingRule_forwardingRuleExternallbExample

TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample

TestAccComputeForwardingRule_forwardingRuleHttpLbExample

TestAccComputeForwardingRule_forwardingRuleInternallbExample

TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example

TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6

TestAccComputeForwardingRule_forwardingRuleL3DefaultExample

TestAccComputeForwardingRule_forwardingRulePscRecreate

TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample

TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample

TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate

TestAccComputeForwardingRule_forwardingRuleVpcPscExample

TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate

TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample

TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample

TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample

TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

TestAccComputePacketMirroring_computePacketMirroringFullExample

TestAccComputeRegionBackendService_basic

TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol

TestAccComputeRegionBackendService_ilbUpdateBasic

TestAccComputeRegionBackendService_ilbUpdateFull

TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample

TestAccComputeRegionBackendService_regionBackendServiceCacheExample

TestAccComputeRegionBackendService_regionBackendServiceExternalExample

TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample

TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample

TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample

TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample

TestAccComputeRegionBackendService_subsettingUpdate

TestAccComputeRegionBackendService_withBackendAndIAP

TestAccComputeRegionBackendService_withBackendInternal

TestAccComputeRegionBackendService_withBackendInternalManaged

TestAccComputeRegionBackendService_withBackendMultiNic

TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate

TestAccComputeRegionBackendService_withSecurityPolicy

TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample

TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample

TestAccComputeRegionTargetHttpProxy_update

TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample

TestAccComputeRegionTargetHttpsProxy_update

TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample

TestAccComputeRegionTargetTcpProxy_update

TestAccComputeRegionUrlMap_advanced

TestAccComputeRegionUrlMap_defaultRouteAction_full_update

TestAccComputeRegionUrlMap_ilbPathUpdate

TestAccComputeRegionUrlMap_ilbRouteUpdate

TestAccComputeRegionUrlMap_noPathRulesWithUpdate

TestAccComputeRegionUrlMap_regionUrlMapBasicExample

TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample

TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample

TestAccComputeRegionUrlMap_update_path_matcher

TestAccComputeRoute_routeIlbExample

TestAccComputeRoute_routeIlbVipExample

TestAccComputeServiceAttachment_serviceAttachmentBasicExample

TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate

TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample

TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample

TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample

Get to know how VCR tests work

modular-magician · 2024-07-17T18:05:02Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeBackendService_trafficDirectorUpdateBasic[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateFull[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionBackendService_basic[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Debug log]
TestAccComputeRegionBackendService_withBackendAndIAP[Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

…der IAP to resource google_compute_region_backend_service

…abled` under IAP to resource google_compute_backend_service

modular-magician · 2024-07-18T16:23:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 95 insertions(+), 83 deletions(-))
google-beta provider: Diff ( 9 files changed, 96 insertions(+), 84 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 22 insertions(+), 35 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

modular-magician · 2024-07-18T16:40:00Z

Tests analytics

Total tests: 968
Passed tests: 893
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample

Get to know how VCR tests work

modular-magician · 2024-07-18T16:44:37Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

…w required `enabled` field and remove the previous required tags under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service (GoogleCloudPlatform#9581)

arnabadg-google marked this pull request as ready for review December 5, 2023 00:03

modular-magician requested a review from shuyama1 December 5, 2023 00:04

c2thorn requested review from c2thorn and removed request for shuyama1 December 5, 2023 15:11

arnabadg-google force-pushed the main branch 2 times, most recently from 6c27b68 to 739e327 Compare December 27, 2023 18:56

arnabadg-google force-pushed the main branch from 739e327 to 9b831a9 Compare December 29, 2023 05:51

arnabadg-google force-pushed the main branch from 6bc0236 to 9c814b6 Compare January 16, 2024 17:26

arnabadg-google force-pushed the main branch 2 times, most recently from 450220a to 0ce21d7 Compare July 10, 2024 21:44

c2thorn requested changes Jul 16, 2024

View reviewed changes

mmv1/third_party/terraform/website/docs/guides/version_6_upgrade.html.markdown Outdated Show resolved Hide resolved

arnabadg-google force-pushed the main branch from 0ce21d7 to 757f83b Compare July 17, 2024 17:07

github-actions bot requested a review from c2thorn July 17, 2024 17:07

arnabadg-google added 2 commits July 17, 2024 22:27

Remove default addition of IAP message and add new fleid enabled un…

893191c

…der IAP to resource google_compute_region_backend_service

Remove default addition of IAP message and add new required fleid `en…

58ea903

…abled` under IAP to resource google_compute_backend_service

arnabadg-google force-pushed the main branch from 757f83b to f877d09 Compare July 17, 2024 22:40

Add upgrade guide entry

b8afdca

arnabadg-google force-pushed the main branch from f877d09 to b8afdca Compare July 17, 2024 22:42

c2thorn approved these changes Jul 18, 2024

View reviewed changes

c2thorn merged commit 29ded33 into GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0 Jul 18, 2024
13 of 14 checks passed

arnabadg-google mentioned this pull request Aug 29, 2024

Google compute backend service: iap parameter is no more optional for provider version >=6.0.0 hashicorp/terraform-provider-google#19273

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove default addition of IAP message in encoder and decoder, add new required `enabled` field and remove the previous required tags under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service #9581

Remove default addition of IAP message in encoder and decoder, add new required `enabled` field and remove the previous required tags under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service #9581

arnabadg-google commented Dec 5, 2023 •

edited

Loading

modular-magician commented Dec 5, 2023

modular-magician commented Dec 5, 2023

modular-magician commented Dec 5, 2023

modular-magician commented Dec 5, 2023

modular-magician commented Dec 5, 2023

modular-magician commented Dec 5, 2023

modular-magician commented Dec 5, 2023

modular-magician commented Dec 27, 2023

modular-magician commented Dec 27, 2023

modular-magician commented Dec 27, 2023

modular-magician commented Dec 27, 2023

shuyama1 commented Dec 28, 2023 •

edited

Loading

modular-magician commented Dec 28, 2023

modular-magician commented Dec 28, 2023

shuyama1 commented Dec 28, 2023

modular-magician commented Dec 28, 2023

modular-magician commented Dec 28, 2023

modular-magician commented Dec 28, 2023

modular-magician commented Dec 29, 2023

modular-magician commented Dec 29, 2023

modular-magician commented Dec 29, 2023

modular-magician commented Jan 16, 2024

arnabadg-google commented Jul 10, 2024

modular-magician commented Jul 10, 2024

modular-magician commented Jul 10, 2024

modular-magician commented Jul 10, 2024

c2thorn left a comment

arnabadg-google commented Jul 17, 2024

modular-magician commented Jul 17, 2024

modular-magician commented Jul 17, 2024

modular-magician commented Jul 17, 2024

modular-magician commented Jul 18, 2024

modular-magician commented Jul 18, 2024

modular-magician commented Jul 18, 2024

Remove default addition of IAP message in encoder and decoder, add new required enabled field and remove the previous required tags under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service #9581

Remove default addition of IAP message in encoder and decoder, add new required enabled field and remove the previous required tags under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service #9581

Conversation

arnabadg-google commented Dec 5, 2023 • edited Loading

modular-magician commented Dec 5, 2023

modular-magician commented Dec 5, 2023

Diff report

modular-magician commented Dec 5, 2023

Tests analytics

Action taken

modular-magician commented Dec 5, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 5, 2023

Diff report

modular-magician commented Dec 5, 2023

Tests analytics

Action taken

modular-magician commented Dec 5, 2023

modular-magician commented Dec 27, 2023

Diff report

modular-magician commented Dec 27, 2023

Tests analytics

Action taken

modular-magician commented Dec 27, 2023

Diff report

modular-magician commented Dec 27, 2023

Tests analytics

Action taken

shuyama1 commented Dec 28, 2023 • edited Loading

modular-magician commented Dec 28, 2023

Diff report

modular-magician commented Dec 28, 2023

Diff report

shuyama1 commented Dec 28, 2023

modular-magician commented Dec 28, 2023

Diff report

modular-magician commented Dec 28, 2023

Tests analytics

Action taken

modular-magician commented Dec 28, 2023

modular-magician commented Dec 29, 2023

Diff report

modular-magician commented Dec 29, 2023

Tests analytics

Action taken

modular-magician commented Dec 29, 2023

modular-magician commented Jan 16, 2024

Diff report

arnabadg-google commented Jul 10, 2024

modular-magician commented Jul 10, 2024

Diff report

modular-magician commented Jul 10, 2024

Tests analytics

Action taken

modular-magician commented Jul 10, 2024

c2thorn left a comment

Choose a reason for hiding this comment

arnabadg-google commented Jul 17, 2024

modular-magician commented Jul 17, 2024

Diff report

modular-magician commented Jul 17, 2024

Tests analytics

Action taken

modular-magician commented Jul 17, 2024

modular-magician commented Jul 18, 2024

Diff report

modular-magician commented Jul 18, 2024

Tests analytics

Action taken

modular-magician commented Jul 18, 2024

Remove default addition of IAP message in encoder and decoder, add new required `enabled` field and remove the previous required tags under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service #9581

Remove default addition of IAP message in encoder and decoder, add new required `enabled` field and remove the previous required tags under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service #9581

arnabadg-google commented Dec 5, 2023 •

edited

Loading

shuyama1 commented Dec 28, 2023 •

edited

Loading