Skip to content

Commit

Permalink
Merge branch 'GoogleCloudPlatform:main' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
arnabadg-google authored Dec 27, 2023
2 parents d43b612 + 998c06e commit 6c27b68
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 3 deletions.
15 changes: 15 additions & 0 deletions .ci/gcb-build-container.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
# substitutions:
# _IMAGE_NAME: 'gcr.io/graphite-docker-images/bash-plus:latest'
# _DIRECTORY: '.ci/containers/bash-plus'

steps:
- name: 'gcr.io/cloud-builders/docker'
args: ['build', '-t', '$_IMAGE_NAME', '.']
dir: '$_DIRECTORY'

images:
- '$_IMAGE_NAME'

logsBucket: 'gs://cloudbuild-container-builder-logs'

6 changes: 3 additions & 3 deletions docs/content/develop/add-handwritten-datasource.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ a new datasource there are 5 steps to doing so.
1. [Add documentation](#add-documentation)

For creating a datasource based off an existing resource you can [make use of the
schema directly](https://github.com/GoogleCloudPlatform/magic-modules/blob/1d293f7bfadacaa20580874c8e8634827fb99a14/mmv1/third_party/terraform/data_sources/data_source_cloud_run_service.go).
Otherwise [implementing the schema directly](https://github.com/GoogleCloudPlatform/magic-modules/blob/1d293f7bfadacaa20580874c8e8634827fb99a14/mmv1/third_party/terraform/data_sources/data_source_google_compute_address.go),
schema directly](https://github.com/GoogleCloudPlatform/magic-modules/blob/8a8ffc3384a59340f47efe97f18611b6672da9bd/mmv1/third_party/terraform/services/cloudrun/data_source_cloud_run_service.go).
Otherwise [implementing the schema directly](https://github.com/GoogleCloudPlatform/magic-modules/blob/8a8ffc3384a59340f47efe97f18611b6672da9bd/mmv1/third_party/terraform/services/compute/data_source_google_compute_address.go),
similar to normal resource creation, is the desired path.

## Resourceless Datasources
Expand All @@ -53,4 +53,4 @@ library, or the raw HTTP client used in MMV1 through `SendRequest`.
- The name of the file is the name of the data source without a `google_` prefix. For example, for `google_compute_instance`, the file is called `compute_instance.html.markdown`
2. Modify the documentation as needed according to [Handwritten documentation style guide]({{< ref "/develop/handwritten-docs-style-guide" >}}).
4. [Generate the providers]({{< ref "/get-started/generate-providers.md" >}})
5. Copy and paste the generated documentation into the Hashicorp Registry's [Doc Preview Tool](https://registry.terraform.io/tools/doc-preview) to see how it is rendered.
5. Copy and paste the generated documentation into the Hashicorp Registry's [Doc Preview Tool](https://registry.terraform.io/tools/doc-preview) to see how it is rendered.

0 comments on commit 6c27b68

Please sign in to comment.