Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project dependency from TestAccApikeysKey_* #11462

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Aug 15, 2024

After deletion_policy is defaulted to PREVENT in google_project resource in #11255, the tests TestAccApikeysKey_* started failing as the projects are prevented to be deleted by default.

Nightly testing results

I don't think it's necessary to create a new project in these tests, so remove the project dependency to fix the tests.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 98 deletions(-))
google-beta provider: Diff ( 2 files changed, 98 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 0
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • apikeys

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApikeysKey_AndroidKey
  • TestAccApikeysKey_BasicKey
  • TestAccApikeysKey_IosKey
  • TestAccApikeysKey_MinimalKey
  • TestAccApikeysKey_ServerKey

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccApikeysKey_AndroidKey[Debug log]
TestAccApikeysKey_BasicKey[Debug log]
TestAccApikeysKey_IosKey[Debug log]
TestAccApikeysKey_MinimalKey[Debug log]
TestAccApikeysKey_ServerKey[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@zli82016 zli82016 requested review from a team and ScottSuarez and removed request for a team August 15, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants