Remove project dependency from TestAccApikeysKey_* #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:372b7c7f15383798536573ebe662c099ac2819d1] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
ScottSuarez
and removed request for
a team
modular-magician
merged commit 45b16d4
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0
1 check passed
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-372b7c7f15383798536573ebe662c099ac2819d1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
deletion_policyis defaulted toPREVENTingoogle_projectresource in GoogleCloudPlatform/magic-modules#11255, the testsTestAccApikeysKey_*started failing as the projects are prevented to be deleted by default.Nightly testing results
I don't think it's necessary to create a new project in these tests, so remove the project dependency to fix the tests.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11462