Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend service default values #11117

Conversation

pawelJas
Copy link
Contributor

@pawelJas pawelJas commented Jul 6, 2024

Removes google global and regional backend service values for outlier_detection subfields.
Sets the correct default values for google regional backed service for balancing_mode and connection_draining_timeout_sec.

Fixes: hashicorp/terraform-provider-google#13478
Fixes: hashicorp/terraform-provider-google#12299
Fixes: hashicorp/terraform-provider-google#15210
Fixes: hashicorp/terraform-provider-google#17257

  • Searched through the issue tracker for an open issue that this either resolves or contributes.
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). - read only field
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Updated default values  of `connection_draining_timeout_sec`, `balancing_mode` and `outlier_detection` in `google_compute_region_backend_service` and `google_compute_backend_service`.

Copy link

github-actions bot commented Jul 6, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 39 insertions(+), 47 deletions(-))
google-beta provider: Diff ( 6 files changed, 48 insertions(+), 48 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field backend.balancing_mode default value changed from CONNECTION to UTILIZATION on google_compute_region_backend_service - reference
  • Field connection_draining_timeout_sec default value changed from 0 to 300 on google_compute_region_backend_service - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_region_backend_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 965
Passed tests: 821
Skipped tests: 73
Affected tests: 71

Click here to see the affected service packages
  • compute

Action taken

Found 71 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_trafficDirectorUpdateBasic
  • TestAccComputeBackendService_trafficDirectorUpdateFull
  • TestAccComputeBackendService_trafficDirectorUpdateLbPolicies
  • TestAccComputeForwardingRule_forwardingRuleExternallbExample
  • TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample
  • TestAccComputeForwardingRule_forwardingRuleHttpLbExample
  • TestAccComputeForwardingRule_forwardingRuleInternallbExample
  • TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example
  • TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6
  • TestAccComputeForwardingRule_forwardingRuleL3DefaultExample
  • TestAccComputeForwardingRule_forwardingRulePscRecreate
  • TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample
  • TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample
  • TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate
  • TestAccComputeForwardingRule_forwardingRuleVpcPscExample
  • TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate
  • TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample
  • TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputePacketMirroring_computePacketMirroringFullExample
  • TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate
  • TestAccComputeRegionBackendService_basic
  • TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol
  • TestAccComputeRegionBackendService_ilbUpdateBasic
  • TestAccComputeRegionBackendService_ilbUpdateFull
  • TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample
  • TestAccComputeRegionBackendService_regionBackendServiceCacheExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample
  • TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample
  • TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample
  • TestAccComputeRegionBackendService_subsettingUpdate
  • TestAccComputeRegionBackendService_withBackendAndIAP
  • TestAccComputeRegionBackendService_withBackendInternal
  • TestAccComputeRegionBackendService_withBackendInternalManaged
  • TestAccComputeRegionBackendService_withBackendMultiNic
  • TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate
  • TestAccComputeRegionBackendService_withSecurityPolicy
  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
  • TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample
  • TestAccComputeRegionTargetHttpProxy_update
  • TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample
  • TestAccComputeRegionTargetHttpsProxy_update
  • TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample
  • TestAccComputeRegionTargetTcpProxy_update
  • TestAccComputeRegionUrlMap_advanced
  • TestAccComputeRegionUrlMap_defaultRouteAction_full_update
  • TestAccComputeRegionUrlMap_ilbPathUpdate
  • TestAccComputeRegionUrlMap_ilbRouteUpdate
  • TestAccComputeRegionUrlMap_noPathRulesWithUpdate
  • TestAccComputeRegionUrlMap_regionUrlMapBasicExample
  • TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample
  • TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample
  • TestAccComputeRegionUrlMap_update_path_matcher
  • TestAccComputeRoute_routeIlbExample
  • TestAccComputeRoute_routeIlbVipExample
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExample
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
  • TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample
  • TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample
  • TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeBackendService_trafficDirectorUpdateBasic[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateFull[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionBackendService_basic[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Debug log]
TestAccComputeRegionBackendService_withBackendAndIAP[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 46 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 7 files changed, 55 insertions(+), 50 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field backend.balancing_mode default value changed from CONNECTION to UTILIZATION on google_compute_region_backend_service - reference
  • Field connection_draining_timeout_sec default value changed from 0 to 300 on google_compute_region_backend_service - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_region_backend_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 965
Passed tests: 886
Skipped tests: 73
Affected tests: 6

Click here to see the affected service packages
  • compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeRegionBackendService_withBackendInternal
  • TestAccComputeRegionBackendService_withBackendMultiNic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@pawelJas
Copy link
Contributor Author

pawelJas commented Jul 8, 2024

@roaks3 I think the failing tests are not related to my change:

  • TestAccComputeForwardingRule_ - Error resolving image name 'debian-cloud/debian-10'
    (among them is TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample and I cannot even find this test)
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy - Cannot delete an access config with a security policy set.

Copy link

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@roaks3
Copy link
Contributor

roaks3 commented Jul 11, 2024

You will need to resolve conflicts within the upgrade guide, but once that's done we can merge

@github-actions github-actions bot requested a review from roaks3 July 12, 2024 06:29
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 44 insertions(+), 48 deletions(-))
google-beta provider: Diff ( 7 files changed, 53 insertions(+), 49 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field backend.balancing_mode default value changed from CONNECTION to UTILIZATION on google_compute_region_backend_service - reference
  • Field connection_draining_timeout_sec default value changed from 0 to 300 on google_compute_region_backend_service - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_region_backend_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 966
Passed tests: 889
Skipped tests: 73
Affected tests: 4

Click here to see the affected service packages
  • compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants