Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend service default values #7723

Conversation

modular-magician
Copy link
Collaborator

Removes google global and regional backend service values for outlier_detection subfields.
Sets the correct default values for google regional backed service for balancing_mode and connection_draining_timeout_sec.

Fixes: hashicorp/terraform-provider-google#13478
Fixes: hashicorp/terraform-provider-google#12299
Fixes: hashicorp/terraform-provider-google#15210
Fixes: hashicorp/terraform-provider-google#17257

  • Searched through the issue tracker for an open issue that this either resolves or contributes.
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). - read only field
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Updated default values  of `connection_draining_timeout_sec`, `balancing_mode` and `outlier_detection` in `google_compute_region_backend_service` and `google_compute_backend_service`.

Derived from GoogleCloudPlatform/magic-modules#11117

[upstream:edcfedd9dfcc7515544c815a6e23795e12697f64]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit e7cf067 into hashicorp:FEATURE-BRANCH-major-release-6.0.0 Jul 12, 2024
3 checks passed
@modular-magician modular-magician deleted the downstream-pr-edcfedd9dfcc7515544c815a6e23795e12697f64 branch November 16, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant