lightning: "no leader" should be a retryable error

[lance6716]

What problem does this PR solve?

Issue Number: close #45673 #46253

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #46300 (f947940) into master (dd593b2) will decrease coverage by 0.6410%.
The diff coverage is 0.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #46300        +/-   ##
================================================
- Coverage   73.3535%   72.7126%   -0.6410%     
================================================
  Files          1284       1305        +21     
  Lines        393272     399467      +6195     
================================================
+ Hits         288479     290463      +1984     
- Misses        86425      90580      +4155     
- Partials      18368      18424        +56     

Flag	Coverage Δ
integration	25.6477% <0.0000%> (?)
unit	73.3908% <0.0000%> (+0.0373%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.0444% <ø> (ø)
parser	85.0667% <ø> (ø)
br	47.8691% <0.0000%> (-4.3794%)	⬇️

[lance6716]

/cc @D3Hunter @GMHDBJD

[lance6716]

/test pull-br-integration-test

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[D3Hunter]

/lgtm

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-08-22 06:09:53.022784738 +0000 UTC m=+1216157.571800709: ☑️ agreed by tangenta.
• 2023-08-22 06:20:59.304468113 +0000 UTC m=+1216823.853484097: ☑️ agreed by D3Hunter.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #46317.

[mittalrishabh]

Shouldn't we check if the leader exist before we do ingestion. I think we should add a check here line 260.

leaderID := j.region.Leader.GetId()

[lance6716]

Shouldn't we check if the leader exist before we do ingestion. I think we should add a check here line 260.

leaderID := j.region.Leader.GetId()

Thanks! That's more accurate to fix this problem.

[Benjamin2037]

/cherry-pick release-6.5

[ti-chi-bot]

@Benjamin2037: new pull request created to branch release-6.5: #46860.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.