Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore .git folder in license check #49156

Closed
lcwangchao opened this issue Dec 4, 2023 · 0 comments · Fixed by #49157
Closed

ignore .git folder in license check #49156

lcwangchao opened this issue Dec 4, 2023 · 0 comments · Fixed by #49157
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@lcwangchao
Copy link
Collaborator

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

license check failed in extension CI:

image

Seems we should ignore some .git folders in .github/licenserc.yml. But I don't know why the CI in tidb repo will pass ...

2. What did you expect to see? (Required)

Verify should pass

3. What did you see instead (Required)

License header check failed

4. What is your TiDB version? (Required)
@lcwangchao lcwangchao added type/bug The issue is confirmed as a bug. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. sig/sql-infra SIG: SQL Infra labels Dec 4, 2023
@lcwangchao lcwangchao mentioned this issue Dec 4, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Dec 4, 2023
@lcwangchao lcwangchao removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Dec 4, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 4, 2023
@lcwangchao
*: exclude **/.git/** in licenserc.yml (#49157)
0fd779c 
close #49156
This was referenced Dec 4, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 4, 2023
@ti-chi-bot
*: exclude **/.git/** in licenserc.yml (#49157) (#49158)
e6503ac 
close #49156
ti-chi-bot bot pushed a commit that referenced this issue Dec 4, 2023
@ti-chi-bot
*: exclude **/.git/** in licenserc.yml (#49157) (#49159)
5a30f1f 
close #49156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: exclude **/.git/** in licenserc.yml lcwangchao/tidb
1 participant
@lcwangchao