Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL may get blocked if tidb restarts/downs #46751

Closed
wjhuang2016 opened this issue Sep 7, 2023 · 0 comments · Fixed by #46752
Closed

DDL may get blocked if tidb restarts/downs #46751

wjhuang2016 opened this issue Sep 7, 2023 · 0 comments · Fixed by #46752
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@wjhuang2016
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Kill TiDB when the owner just cleans tidb_mdl_info while not cleaning the etcd info.

If so, that DDL is blocked.

2. What did you expect to see? (Required)

DDL finish finally.

3. What did you see instead (Required)

DDL get blocked

4. What is your TiDB version? (Required)

6.5 7.1 master
@wjhuang2016 wjhuang2016 added type/bug The issue is confirmed as a bug. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major labels Sep 7, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Sep 7, 2023
@wjhuang2016 wjhuang2016 mentioned this issue Sep 7, 2023
Merged
12 tasks
@wjhuang2016 wjhuang2016 removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Sep 7, 2023
@wjhuang2016 wjhuang2016 changed the title DDL may get blocked if tidb is killed DDL may get blocked if tidb restarts/downs Sep 7, 2023
ti-chi-bot bot pushed a commit that referenced this issue Sep 8, 2023
@wjhuang2016
ddl: relax the check in ownerCheckAllVersions (#46752)
a677716 
close #46751
This was referenced Sep 8, 2023
Closed
Merged
@jebter jebter added the component/ddl This issue is related to DDL of TiDB. label Sep 11, 2023
wjhuang2016 added a commit to wjhuang2016/tidb that referenced this issue Sep 19, 2023
@wjhuang2016
ddl: relax the check in ownerCheckAllVersions (pingcap#46752)
a487aec 
close pingcap#46751
ti-chi-bot bot pushed a commit that referenced this issue Oct 12, 2023
@ti-chi-bot
ddl: relax the check in ownerCheckAllVersions (#46752) (#46794)
369d7bc 
close #46751
@Benjamin2037 Benjamin2037 mentioned this issue Oct 18, 2023
Merged
18 tasks
@wjhuang2016 wjhuang2016 mentioned this issue Nov 23, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 27, 2023
@ti-chi-bot
ddl: fix a bug that MDL may progress unexpectedly or block forever (#…
bec245b 
…46921) (#47068)

close #46751, close #46920
@Benjamin2037 Benjamin2037 mentioned this issue Nov 30, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: relax the check in ownerCheckAllVersions wjhuang2016/tidb
2 participants
@jebter @wjhuang2016