Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning wrongly use int64 to save NEXT_GLOBAL_ROW_ID #45427

Closed
lance6716 opened this issue Jul 18, 2023 · 0 comments · Fixed by #45614
Closed

lightning wrongly use int64 to save NEXT_GLOBAL_ROW_ID #45427

lance6716 opened this issue Jul 18, 2023 · 0 comments · Fixed by #45614
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

pingcap/tiflow#9391 (comment)

tidb/br/pkg/lightning/backend/tidb/tidb.go

Line 851 in f1b9da1

err = rows.Scan(&dbName, &tblName, &columnName, &nextID, &idType)

should use unit64 here

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@lance6716 lance6716 added the type/bug The issue is confirmed as a bug. label Jul 18, 2023
@aytrack aytrack added severity/major component/lightning This issue is related to Lightning of TiDB. labels Jul 18, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Jul 18, 2023
@lyzx2001 lyzx2001 mentioned this issue Jul 27, 2023
Merged
12 tasks
@lance6716 lance6716 added affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 and removed may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Aug 9, 2023
ti-chi-bot bot pushed a commit that referenced this issue Aug 9, 2023
@lyzx2001
lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (#45614)
b59ce11 
close #45427
This was referenced Aug 9, 2023
Merged
Closed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue Aug 9, 2023
@lyzx2001 @ti-chi-bot
lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (pingca…
758bc90 
…p#45614)

close pingcap#45427
@ti-chi-bot ti-chi-bot mentioned this issue Aug 9, 2023
Open
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue Aug 9, 2023
@lyzx2001 @ti-chi-bot
lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (pingca…
9bfac72 
…p#45614)

close pingcap#45427
This was referenced Aug 9, 2023
Open
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 15, 2023
@ti-chi-bot
lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (#45614) (
4973f87 
#45944)

close #45427
ti-chi-bot bot pushed a commit that referenced this issue Aug 25, 2023
@ti-chi-bot
lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (#45614) (
4cb399e 
#45940)

close #45427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 lyzx2001/tidb
2 participants
@lance6716 @aytrack