Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When autoid service panic unexpected, the recovering time is a bit too long #46454

Closed
tiancaiamao opened this issue Aug 28, 2023 · 0 comments · Fixed by #46455
Closed

When autoid service panic unexpected, the recovering time is a bit too long #46454

tiancaiamao opened this issue Aug 28, 2023 · 0 comments · Fixed by #46455
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.

Comments

@tiancaiamao
Copy link
Contributor

Enhancement

When autoid service leader panic, the follower need to wait the lease timeout to take over the leader's role.
The lease is 60s, which is a bit too long...

For DDL service, it's also 60s, and it's the default value https://pkg.go.dev/go.etcd.io/etcd/clientv3/concurrency#WithTTL
DDL is offline service, so 60s is tolerable.
But autoid allocating is online service, the custome may not expect it take so long to recover.
@tiancaiamao tiancaiamao added the type/enhancement The issue or PR belongs to an enhancement. label Aug 28, 2023
@tiancaiamao tiancaiamao mentioned this issue Aug 28, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 4, 2023
@tiancaiamao
autoid_service,owner: change autoid service's etcd lease to 10s (#46455)
18ecfba 
close #46454
@ti-chi-bot ti-chi-bot mentioned this issue Sep 5, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Sep 6, 2023
ti-chi-bot bot pushed a commit that referenced this issue Sep 6, 2023
@ti-chi-bot
autoid_service,owner: change autoid service's etcd lease to 10s (#46455…
2d63b90 
…) (#46653)

close #46454
@jebter jebter added the sig/sql-infra SIG: SQL Infra label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

autoid_service,owner: change autoid service's etcd lease to 10s tiancaiamao/tidb
3 participants
@tiancaiamao @jebter @ti-chi-bot