Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebs br: fsr is not really enabled #48629

Closed
BornChanger opened this issue Nov 15, 2023 · 10 comments · Fixed by #48627
Closed

ebs br: fsr is not really enabled #48629

BornChanger opened this issue Nov 15, 2023 · 10 comments · Fixed by #48627
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/critical type/enhancement The issue or PR belongs to an enhancement.

Comments

@BornChanger
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Call AWS API to enable snapshot fsr
Checking snapshot status until snapshot status is fsr enabled
Create ebs volumes
Disable fsr right away

2. What did you expect to see? (Required)

The restored volume should have the best performance

3. What did you see instead (Required)

The volume's performance is bad as if never been fsr enabled

4. What is your TiDB version? (Required)
@BornChanger BornChanger added the type/bug The issue is confirmed as a bug. label Nov 15, 2023
@BornChanger
Copy link
Contributor Author

/component br

@ti-chi-bot ti-chi-bot bot added the component/br This issue is related to BR of TiDB. label Nov 15, 2023
@BornChanger
Copy link
Contributor Author

/severity critical

@BornChanger
Copy link
Contributor Author

/label affects-6.5

@ti-chi-bot ti-chi-bot bot added affects-6.5 This bug affects the 6.5.x(LTS) versions. and removed may-affects-6.5 labels Nov 15, 2023
@BornChanger
Copy link
Contributor Author

/label affects-7.1

@ti-chi-bot ti-chi-bot bot added affects-7.1 This bug affects the 7.1.x(LTS) versions. and removed may-affects-7.1 labels Nov 15, 2023
@BornChanger
Copy link
Contributor Author

/label affects-7.5

@ti-chi-bot ti-chi-bot bot added affects-7.5 This bug affects the 7.5.x(LTS) versions. and removed may-affects-7.5 labels Nov 15, 2023
@BornChanger BornChanger mentioned this issue Nov 15, 2023
Merged
13 tasks
@BornChanger
Copy link
Contributor Author

/remove-label may-affect-5.3

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 15, 2023

@BornChanger: The label(s) may-affect-5.3 cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, affects-5.3, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, may-affects-5.3, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5.

In response to this:

/remove-label may-affect-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor Author

/remove-label may-affects-5.3

@ti-chi-bot ti-chi-bot bot removed the may-affects-5.3 This bug maybe affects 5.3.x versions. label Nov 17, 2023
@BornChanger
Copy link
Contributor Author

/remove-label may-affects-5.4

@ti-chi-bot ti-chi-bot bot removed the may-affects-5.4 This bug maybe affects 5.4.x versions. label Nov 17, 2023
@BornChanger
Copy link
Contributor Author

/remove-label may-affects-6.1

ti-chi-bot bot pushed a commit that referenced this issue Nov 21, 2023
@BornChanger
ebs br: make sure fsr credit is full filled (#48627)
711e95f 
close #48629
@ti-chi-bot ti-chi-bot mentioned this issue Nov 21, 2023
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue Nov 21, 2023
@BornChanger @ti-chi-bot
ebs br: make sure fsr credit is full filled (pingcap#48627)
d659775 
close pingcap#48629
This was referenced Nov 21, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 21, 2023
@ti-chi-bot
ebs br: make sure fsr credit is full filled (#48627) (#48742)
981e19a 
close #48629
@seiya-annie seiya-annie added type/enhancement The issue or PR belongs to an enhancement. type/new-feature and removed type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement. type/new-feature labels Nov 29, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
@ti-chi-bot
ebs br: make sure fsr credit is full filled (#48627) (#48743)
c870a52 
close #48629
ti-chi-bot bot pushed a commit that referenced this issue Feb 20, 2024
@ti-chi-bot
ebs br: make sure fsr credit is full filled (#48627) (#48744)
b31b3e5 
close #48629
guoshouyan pushed a commit to guoshouyan/tidb that referenced this issue Mar 5, 2024
@ti-chi-bot
ebs br: make sure fsr credit is full filled (pingcap#48627) (pingcap#…
57a449d 
…48742) (pingcap#27)

close pingcap#48629

Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/critical type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ebs br: make sure fsr credit is full filled BornChanger/tidb
2 participants
@seiya-annie @BornChanger