Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The function core.(*LogicalProjection).DeriveStats encountered a panic error #47331

Closed
King-Dylan opened this issue Sep 27, 2023 · 8 comments · Fixed by #47883
Closed

The function core.(*LogicalProjection).DeriveStats encountered a panic error #47331

King-Dylan opened this issue Sep 27, 2023 · 8 comments · Fixed by #47883
Assignees
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@King-Dylan
Copy link
Contributor

King-Dylan commented Sep 27, 2023

Bug Report

The function core.(*LogicalProjection).DeriveStats encountered a panic error.

1. Minimal reproduce step (Required)

SQL> create table t1(id1 varchar(2) DEFAULT '00',id2 varchar(30) NOT NULL ,id3 datetime DEFAULT NULL,id4 varchar(100) NOT NULL DEFAULT 'ecifdata',id5 datetime NOT NULL DEFAULT CURRENT_TIMESTAMP ,id6 int(11) DEFAULT NULL,id7 int(11) DEFAULT NULL,  UNIQUE KEY `UI_id2` (`id2`),  KEY `ix_id1` (`id1`));
SQL> create table t2(id10  varchar(40) NOT NULL ,id2 varchar(30) NOT NULL,  KEY `IX_id2` (`id2`),
PRIMARY KEY (`id10`) /*T![clustered_index] NONCLUSTERED */ );
SQL> create table t3(id20  varchar(40) DEFAULT NULL,  UNIQUE KEY `IX_id20` (`id20`) );
SQL> explain UPDATE t1 a
SET a.id1     = '04',
      a.id3 = CURRENT_TIMESTAMP,
      a.id4      = SUBSTRING_INDEX(USER(), '@', 1),
      a.id5    = CURRENT_TIMESTAMP
WHERE a.id1 = '03'
  AND a.id6 - IFNULL(a.id7, 0) =
      (SELECT COUNT(1)
         FROM t2 b, t3 c
        WHERE b.id10 = c.id20
          AND b.id2 = a.id2
          AND b.id2 in (select rn.id2
                              from t1 rn
                             WHERE rn.id1 = '03'));

2. What did you expect to see? (Required)

No errors

3. What did you see instead (Required)

ERROR 1105 (HY000): runtime error: index out of range [8] with length 8

stack:

[err="runtime error: index out of range [8] with length 8"] [stack="github.com/pingcap/tidb/server.(*clientConn).Run.func1\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:1090\nruntime.gopanic\n\t/usr/local/go/src/runtime/panic.go:884\ngithub.com/pingcap/tidb/executor.(*Compiler).Compile.func1\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/compiler.go:72\nruntime.gopanic\n\t/usr/local/go/src/runtime/panic.go:884\nruntime.goPanicIndex\n\t/usr/local/go/src/runtime/panic.go:113\ngithub.com/pingcap/tidb/planner/core.(*LogicalProjection).DeriveStats\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/stats.go:1101\ngithub.com/pingcap/tidb/planner/core.(*baseLogicalPlan).recursiveDeriveStats\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/stats.go:133\ngithub.com/pingcap/tidb/planner/core.(*baseLogicalPlan).recursiveDeriveStats\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/stats.go:126\ngithub.com/pingcap/tidb/planner/core.(*baseLogicalPlan).recursiveDeriveStats\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/stats.go:126\ngithub.com/pingcap/tidb/planner/core.(*baseLogicalPlan).recursiveDeriveStats\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/stats.go:126\ngithub.com/pingcap/tidb/planner/core.(*baseLogicalPlan).recursiveDeriveStats\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/stats.go:126\ngithub.com/pingcap/tidb/planner/core.physicalOptimize\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/optimizer.go:889\ngithub.com/pingcap/tidb/planner/core.DoOptimize\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/optimizer.go:296\ngithub.com/pingcap/tidb/planner/core.(*PlanBuilder).buildUpdate\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/logical_plan_builder.go:5479\ngithub.com/pingcap/tidb/planner/core.(*PlanBuilder).Build\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/planbuilder.go:808\ngithub.com/pingcap/tidb/planner.buildLogicalPlan\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/optimize.go:461\ngithub.com/pingcap/tidb/planner.optimize\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/optimize.go:382\ngithub.com/pingcap/tidb/planner.Optimize\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/optimize.go:245\ngithub.com/pingcap/tidb/planner/core.(*PlanBuilder).buildExplain\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/planbuilder.go:4808\ngithub.com/pingcap/tidb/planner/core.(*PlanBuilder).Build\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/planbuilder.go:779\ngithub.com/pingcap/tidb/planner.buildLogicalPlan\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/optimize.go:461\ngithub.com/pingcap/tidb/planner.optimize\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/optimize.go:382\ngithub.com/pingcap/tidb/planner.Optimize\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/optimize.go:245\ngithub.com/pingcap/tidb/executor.(*Compiler).Compile\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/compiler.go:116\ngithub.com/pingcap/tidb/session.(*session).ExecuteStmt\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/session/session.go:2199\ngithub.com/pingcap/tidb/server.(*TiDBContext).ExecuteStmt\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/driver_tidb.go:252\ngithub.com/pingcap/tidb/server.(*clientConn).handleStmt\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:2122\ngithub.com/pingcap/tidb/server.(*clientConn).handleQuery\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:1972\ngithub.com/pingcap/tidb/server.(*clientConn).dispatch\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:1403\ngithub.com/pingcap/tidb/server.(*clientConn).Run\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:1152\ngithub.com/pingcap/tidb/server.(*Server).onConn\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/server.go:648"]

4. What is your TiDB version? (Required)

@King-Dylan King-Dylan added the type/bug The issue is confirmed as a bug. label Sep 27, 2023
@King-Dylan King-Dylan changed the title Build plan The function core.(*LogicalProjection).DeriveStats encountered a panic error Sep 27, 2023
@King-Dylan
Copy link
Contributor Author

/assign hi-rustin

@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Oct 7, 2023
@King-Dylan
Copy link
Contributor Author

King-Dylan commented Oct 13, 2023

Need raise the priority, https://internal.pingcap.net/jira/projects/GTS/issues/GTS-65

@King-Dylan
Copy link
Contributor Author

@chrysan cc

@Rustin170506
Copy link
Member

I will take a look.

@Rustin170506
Copy link
Member

Need raise the priority, internal.pingcap.net/jira/projects/GTS/issues/GTS-65

Please do not post the internal-only link on GitHub. Thanks!

@ti-chi-bot ti-chi-bot added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label Oct 23, 2023
@Rustin170506 Rustin170506 moved this to 📋 Backlog in 🎒My Work Oct 31, 2023
@Rustin170506 Rustin170506 moved this from 📋 Backlog to 🏊WIP in 🎒My Work Nov 6, 2023
@Rustin170506 Rustin170506 moved this from 🏊WIP to 📋 Backlog in 🎒My Work Nov 6, 2023
@Rustin170506 Rustin170506 moved this from 📋 Backlog to 🏊WIP in 🎒My Work Nov 20, 2023
@Rustin170506
Copy link
Member

The code panic here:

p.StatsInfo().ColNDVs[selfSchema.Columns[i].UniqueID] = childProfile.RowCount

@Rustin170506
Copy link
Member

This LogicalProjection has 8 exprs and only has 7 columns in the schema. So we panic when we get the columns[8].

@Rustin170506 Rustin170506 added affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Nov 22, 2023
@Rustin170506 Rustin170506 removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. labels Nov 22, 2023
@Rustin170506
Copy link
Member

Rustin170506 commented Nov 22, 2023

Through my investigation, I identified several key points:

  1. The panic occurs during DeriveStats: p.StatsInfo().ColNDVs[selfSchema.Columns[i].UniqueID] = childProfile.RowCount.
  2. There's a discrepancy in the number of expressions and schema columns: the plan has 8 expressions but only 7 columns in the schema.
  3. The logic plan causing the panic is a projection (ID 25), generated by the joinReOrderSolver.
  4. Post-debugging, I noted that the schema undergoes changes after the LogicalProjection.PruneColumns process.
  5. On further debugging the PruneColumns function individually, I discovered that the schema of projection#25 is affected even before it's reached in the process.
  6. This led me to suspect a memory issue. Notably, projection#18 and projection#25 appear to share the same schema memory address (0x14006b557c0).
  7. Consequently, when a column is pruned from projection#18, projection#25 becomes corrupted, leading to a mismatch between expressions and columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants