Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove vuex store #10372

Merged
merged 2 commits into from
Jan 22, 2024
Merged

refactor: remove vuex store #10372

merged 2 commits into from
Jan 22, 2024

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jan 19, 2024

Description

Removes the vuex store dependency from the project after successfully migrating all store modules to pinia.

I also accumulated all the related changelog items into one big changelog.

Summary

All store modules have been migrated to a pinia store module. Please see the linked issue down below for a list of all migrated stores and how to use them now.

There are a number of things that have been removed and/or moved into pinia composables instead:

Globals:

  • store and $store variables have been removed.
  • ConfigurationManager has been removed. The config now sits inside the configuration store.

App framework:

  • announceStore has been removed. There is no need for apps to announce stores to the runtime. If you need to use a store in your app, simply create a pinia store module and use it.
  • announceExtensions has been removed. The proper way for an app to register file extensions is via the extensions property inside the appInfo object.
  • requestStore has been removed. There is no need to request specific stores. All stores that web-pkg provides can be imported and accessed via their composables.
  • enabled callback as well as the name callback of the AppNavigationItem no longer have the capabilities parameter.
  • store param of the ClassicApplicationScript has been removed.

Composables:

  • useStore has been removed. Use the pinia for the store you want to use instead.
  • useAccessToken has been removed. It now sits inside the auth store.
  • usePublicLinkContext has been removed. It now sits inside the auth store.
  • usePublicLinkPassword has been removed. It now sits inside the auth store.
  • usePublicLinkToken has been removed. It now sits inside the auth store.
  • useUserContext has been removed. It now sits inside the auth store.
  • useConfigurationManager has been removed. The config now sits inside the configuration store.
  • use...Capability composables have been removed. Capablities now sit inside the capability store.

For store specific changes please see the linked issue and PRs down below.

#10212 (modal store)
#10240 (user store)
#10307 (removal of dynamic nav items)
#10309 (messages store)
#10316 (spaces store)
#10323 (auth store)
#10326 (remove left sidebar state from store)
#10329 (register nav items via extension registry)
#10331 (app store)
#10336 (configuration store)
#10338 (remove searched files from store)
#10341 (clipboard store)
#10346 (remove external app from store)
#10349 (remove highlightedFile from store)
#10362 (shares store)
#10363 (remove file versions from vuex files store module)
#10368 (resources store)

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍😍😍😍

.npmrc Outdated Show resolved Hide resolved
@delete-merged-branch delete-merged-branch bot deleted the branch master January 22, 2024 09:45
Removes the vuex store dependency from the project after successfully migrating all store modules to pinia.
@JammingBen JammingBen marked this pull request as ready for review January 22, 2024 09:49
@JammingBen JammingBen changed the base branch from files-to-pinia-store to master January 22, 2024 09:51
Copy link

sonarcloud bot commented Jan 22, 2024

@JammingBen JammingBen merged commit f14c2ea into master Jan 22, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-vuex-store branch January 22, 2024 10:33
@JammingBen JammingBen mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from vuex store to pinia
2 participants