Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove searched files from store #10338

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jan 16, 2024

Description

The filesSearched store state didn't seem to be used at all, so this removes it from it (including all related mutations). Also removes the filesAll getter since it's now the same as files.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jan 16, 2024
Copy link

update-docs bot commented Jan 16, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

The `filesSearched` store state didn't seem to be used at all, so this removes it from it (including all related mutations).
@JammingBen JammingBen force-pushed the remove-searched-files-from-store branch from 73a6b32 to 70b1eca Compare January 16, 2024 08:47
Copy link

sonarcloud bot commented Jan 16, 2024

@JammingBen JammingBen merged commit bebe3a6 into master Jan 16, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-searched-files-from-store branch January 16, 2024 11:02
ownclouders pushed a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants