Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moves resources to pinia store #10368

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jan 19, 2024

Description

Removes the resources store module of the files app and implements it as a pinia store instead. All store functionality can be accessed via the new useResourcesStore composable.

The former files store has been split up into the following parts (partly already done in other PRs):

The following former files store parts are no longer inside any store:

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jan 19, 2024
@JammingBen JammingBen mentioned this pull request Jan 19, 2024
11 tasks
@JammingBen JammingBen force-pushed the files-to-pinia-store branch 2 times, most recently from 43ee156 to dbca1a3 Compare January 19, 2024 10:49
@JammingBen JammingBen marked this pull request as ready for review January 19, 2024 11:33
Removes the resources store module of the files app and implements it as a pinia store instead. All store functionality can be accessed via the new `useResourcesStore` composable.
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

37.27% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@JammingBen JammingBen mentioned this pull request Jan 19, 2024
7 tasks
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍😍😍😍

await nextTick()
await nextTick()
await nextTick()
await nextTick()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂😂😂

@JammingBen JammingBen merged commit f75af5f into master Jan 22, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the files-to-pinia-store branch January 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants