Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move shares from vuex store to pinia #10362

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jan 18, 2024

Description

Removes the spaces (and their CRUD actions) from the vuex files store module and integrates them in a pinia store instead: useSpacesStore().

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jan 18, 2024
Copy link

update-docs bot commented Jan 18, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the shares-to-pinia branch 2 times, most recently from 0bca7e6 to 8f2e5a3 Compare January 18, 2024 10:55
@JammingBen JammingBen marked this pull request as ready for review January 18, 2024 11:15
@dschmidt dschmidt enabled auto-merge (squash) January 18, 2024 11:15
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@dschmidt dschmidt merged commit 8a15a7d into master Jan 18, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the shares-to-pinia branch January 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants