refactor: remove highlightedFile getter from store #10349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the `highlightedFile` getter from the vuex file store. The reason behind this decision is that the getter was really opaque to use as it sometimes referred to the current folder and sometimes to the first selected file (which is already confusing in itself since the user can highlight more than 1 resources).
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
dschmidt
approved these changes
Jan 17, 2024
ownclouders
pushed a commit
that referenced
this pull request
Jan 17, 2024
refactor: remove highlightedFile getter from store
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
highlightedFilegetter from the vuex file store. The reason behind this decision is that the getter was really opaque to use as it sometimes referred to the current folder and sometimes to the first selected file (which is already confusing in itself since the user can highlight more than 1 resources).Related Issue
Types of changes