Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clipboard from files store #10341

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jan 16, 2024

Description

Removes the clipboard from the vuex file store and adds a slim pinia store instead. There is no need for that to be coupled in any file store.

Also, moves the pasteSelectedFiles method from the files store into its corresponding action composable. Again, not really needed in a store since the action is the only place where this is being called. The ResourceTransfer component needed to be moved to web-pkg for this to happen.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

update-docs bot commented Jan 16, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the remove-clipboard-from-files-store branch from f9cc6a3 to 2202a7a Compare January 16, 2024 12:04
@JammingBen JammingBen self-assigned this Jan 16, 2024
@JammingBen JammingBen force-pushed the remove-clipboard-from-files-store branch from 2202a7a to 3bf3d81 Compare January 16, 2024 14:32
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

38.89% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@JammingBen JammingBen marked this pull request as ready for review January 16, 2024 14:50
@JammingBen JammingBen merged commit a7fdba9 into master Jan 16, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-clipboard-from-files-store branch January 16, 2024 15:11
ownclouders pushed a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants