refactor: remove file versions from vuex files store module #10363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
remove-file-versions-from-store
branch
2 times, most recently
from
2ded9f7
to
87f7ed9
Compare
dschmidt
approved these changes
Jan 18, 2024
| @@ -191,6 +185,14 @@ function getMountedWrapper({ | |||
| downloadFile | |||
| } | |||
| mocks.$clientService.webdav.getFileInfo.mockResolvedValue(mock<Resource>({ id: '1' })) | |||
| mocks.$clientService.webdav.listFileVersions.mockImplementation(() => { | |||
| if (loadingStateDelay > 0) { | |||
| return new Promise((res) => setTimeout(() => res(versions), loadingStateDelay)) | |||
There was a problem hiding this comment.
if loadingStateDelay defaults to 0 anyway - can't we just always run this branch? What benefit does the check add? a tick less? 🤷🏻
There was a problem hiding this comment.
Good catch, fixed. It's necessary for checking the loading spinner, since we still don't have a way to mock tasks properly.
There was a problem hiding this comment.
Hmm CI seems unhappy that way, so I reverted it
JammingBen
force-pushed
the
remove-file-versions-from-store
branch
from
87f7ed9
to
e13492c
Compare
Removes the file versions from the vuex files store module because there is no need to store them in any store.
JammingBen
force-pushed
the
remove-file-versions-from-store
branch
from
e13492c
to
9207629
Compare
|
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the file versions from the vuex files store module because there is no need to store them in any store.
Related Issue
Types of changes