Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove vuex store in external app #10346

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jan 16, 2024

Description

Removes the vuex store module in the external app.

Also refactors the external app handling in general so that external mime types are now registered as ApplicationFileExtension. This allows us to:

  • handle file actions for internal and external apps the same (mostly), which results in a lot less boilerplate code.
  • keep the external app logic inside the corresponding package while not leaking into other apps like before.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

update-docs bot commented Jan 16, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen mentioned this pull request Jan 16, 2024
11 tasks
@JammingBen JammingBen force-pushed the remove-external-vuex-store branch 4 times, most recently from df7b3e0 to 0701481 Compare January 16, 2024 14:46
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm biased, but I love it :)

@JammingBen JammingBen marked this pull request as ready for review January 16, 2024 15:00
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

13.33% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@JammingBen JammingBen merged commit 0252ce7 into master Jan 16, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-external-vuex-store branch January 16, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve business logic leaks ofweb-app-external
2 participants