refactor: move app vuex store to pinia #10331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
apps-to-pinia-store
branch
2 times, most recently
from
0e639c8
to
3d1cdeb
Compare
11 tasks
JammingBen
force-pushed
the
apps-to-pinia-store
branch
3 times, most recently
from
b2b5afd
to
bcafac1
Compare
dschmidt
approved these changes
Jan 15, 2024
packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFile.ts
Show resolved
Hide resolved
Removes the vuex app store module in favour of a pinia store instead. Also cleans up the app types a bit, although this is still a bit messy due to some weird naming choices in the past. That's something for a follow-up though. Also removes the `announceExtensions` method inside the app's `ready` hook, which could be used to register file editors. Apparently it was not used by any app because there is already another way to register file editors, which is via the `extensions` property inside the `appInfo` object.
JammingBen
force-pushed
the
apps-to-pinia-store
branch
from
d90facd
to
57fadbc
Compare
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the vuex app store module in favour of a pinia store instead.
I also tried cleaning up and improving the naming and types of app related stuff. It's not all perfect yet, but it's definitely an improvement. The most notable change here is that
extensionsinside theappInfoobject are now of typeApplicationFileExtension[], since they have nothing to do with our extension library, but are file extensions.Also, there is no such thing as a
newFileHandler. This is basically aApplicationFileExtensionwith an addednewFileMenuthat includes amenuTitle.Breaking changes for developers
announceExtensionsmethod inside the app'sreadyhook, which could be used to register file editors. Apparently it was not used by any app because there is already another way to register file editors, which is via theextensionsproperty inside theappInfoobject.$storevariable. The recommended way to use the vuex store is viauseStore.Related Issue
Types of changes