Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dynamic nav items #10307

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

JammingBen
Copy link
Collaborator

Description

Removes the code for registering dynamic nav items since this is no longer possible.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Removes the code for registering dynamic nav items since this is no longer possible.
@JammingBen JammingBen self-assigned this Jan 8, 2024
Copy link

update-docs bot commented Jan 8, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Jan 8, 2024

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less dead code is good code 👍

@kulmann kulmann merged commit 68c74cd into master Jan 8, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clean-up-navigation-store branch January 8, 2024 15:26
@JammingBen JammingBen mentioned this pull request Jan 19, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants