refactor: move spaces to pinia store #10316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
11 tasks
JammingBen
force-pushed
the
spaces-to-pinia
branch
6 times, most recently
from
b868659 to
331435d
Compare
JammingBen
commented
Jan 10, 2024
| @@ -4,16 +4,12 @@ import auth from './auth' | |||
| import config from './config' | |||
| import user from './user' | |||
| import navigation from './navigation' | |||
| import spaces from './spaces' | |||
|
|
|||
| const strict = process.env.NODE_ENV === 'development' | |||
There was a problem hiding this comment.
This causes issues because spaces are now sitting in pinia store (spaces store) as well as in vuex store (files store). Since this only affects dev environments and we will get rid of vuex eventually, I'd propose to disable strict mode.
Removes the vuex spaces store module and adds a pinia store for spaces instead. Note that this is a breaking change for developers!
JammingBen
force-pushed
the
spaces-to-pinia
branch
from
331435d to
4e17e14
Compare
|
dschmidt
approved these changes
Jan 11, 2024
|
💖💖💖 |
ownclouders
pushed a commit
that referenced
this pull request
Jan 12, 2024
refactor: move spaces to pinia store
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the vuex spaces store module and adds a pinia store for spaces instead. The pinia store can be accessed via the new
useSpacesStore()composable.The spaces store could still be refactored a little bit, but I wanted to keep the scope here as small as possible. What I don't like is that the store doesn't feel consistent to me. E.g. The method
addSpacessimply adds given spaces to the store, whereasaddSpaceMembersdoes not only add space members to the store, but does also requests to the server.Note that this is a breaking change for developers!
Related Issue
Types of changes