Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and enable tfproviderlint V001 check: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch() #11872

Closed
10 of 28 tasks
bflad opened this issue Feb 3, 2020 · 1 comment
Closed
10 of 28 tasks

Fix and enable tfproviderlint V001 check: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch() #11872

bflad opened this issue Feb 3, 2020 · 1 comment
Labels
linter Pertains to changes to or issues with the various linters. stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@bflad
Copy link
Contributor

bflad commented Feb 3, 2020 •
edited by gdavison
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The custom validation functions noted by this check can be implemented by standard Terraform Plugin SDK helper/validation functions. Some may require multiple function usage such as validation.All() with validation.StringLenBetween() and validation.StringMatch(). See also: https://github.com/bflad/tfproviderlint/blob/master/passes/V001/README.md

Due to the amount of reports and potential review complexity, any fixes should likely be done per-resource.

/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_app_cookie_stickiness_policy.go:32:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_appsync_datasource.go:33:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_appsync_function.go:39:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_appsync_graphql_api.go:107:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_event_permission.go:217:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_event_permission.go:230:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_event_permission.go:239:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_log_stream.go:126:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_codebuild_project.go:1625:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_codebuild_project.go:1645:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_db_instance.go:251:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_docdb_cluster.go:125:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elastic_transcoder_pipeline.go:92:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elasticsearch_domain.go:73:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_glacier_vault.go:34:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_group.go:134:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_instance_profile.go:48:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_instance_profile.go:68:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_policy.go:50:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_policy.go:69:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_role.go:46:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_role.go:66:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_user.go:247:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_neptune_cluster.go:116:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_organizations_account.go:302:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_organizations_account.go:322:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_rds_cluster.go:264:19: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_redshift_cluster.go:973:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_redshift_cluster.go:994:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_redshift_cluster.go:1016:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_redshift_cluster.go:1034:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_redshift_cluster.go:1050:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_redshift_parameter_group.go:239:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_redshift_security_group.go:251:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_redshift_subnet_group.go:188:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpn_connection.go:616:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:60:9: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:119:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:133:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:142:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:163:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:184:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:201:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:254:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:279:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:300:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:321:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:344:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:369:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:390:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:411:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:432:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:457:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:475:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:493:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:517:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:531:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:549:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:567:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:597:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:615:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:632:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:649:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:663:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:681:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:695:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:730:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:744:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:795:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:814:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:834:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:854:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:895:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:945:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:993:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1006:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1037:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1085:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1099:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1112:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1131:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1150:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1169:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1185:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1214:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1232:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1245:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1276:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1293:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1310:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1327:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1340:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1354:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1368:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1393:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1430:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1439:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1453:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1462:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1475:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1492:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1509:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1526:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1542:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1558:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1574:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1582:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1598:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1614:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1630:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1646:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1662:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1678:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1694:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1714:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1734:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1750:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1766:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1781:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1803:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1818:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1831:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1844:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1852:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1860:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1919:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:1973:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2008:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2024:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2073:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2082:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2095:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2158:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2172:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2185:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2210:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2232:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2245:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2259:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2272:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2286:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2307:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2328:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2341:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2359:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2373:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/validators.go:2388:1: V001: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch()

Definition of Done

  • Fix V001 reports
  • In GNUmakefile, add -V001 to tfproviderlint command under lint target and have TravisCI testing pass

Additional References
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Feb 3, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 3, 2020
bflad added a commit that referenced this issue Feb 3, 2020
@bflad
tests/provider: Enable new passing tfproviderlint checks
dd7482b 
Gaps in `tfproviderlint` checking are covered by the following issues:

Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #9954 (fix and enable R004)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
@bflad bflad mentioned this issue Feb 3, 2020
Merged
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 3, 2020
bflad added a commit that referenced this issue Feb 4, 2020
@bflad
tests/provider: Enable new passing tfproviderlint checks (#11873)
e1e3709 
Gaps in `tfproviderlint` checking are covered by the following issues:

Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #9954 (fix and enable R004)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
bflad added a commit that referenced this issue Feb 19, 2020
@bflad
tests/provider: Enable passing tfproviderlint v0.10.0 checks
2f5388a 
Reference: #12074

Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues:

Reference: #11888 (fix and enable AWSAT001)
Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #12083 (fix and enable R007, R008)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
@bflad bflad mentioned this issue Feb 19, 2020
Merged
bflad added a commit that referenced this issue Mar 10, 2020
@bflad
tests/provider: Enable passing tfproviderlint v0.10.0 checks (#12088)
fe8d04c 
Reference: #12074

Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues:

Reference: #11888 (fix and enable AWSAT001)
Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #12083 (fix and enable R007, R008)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
@melamity melamity mentioned this issue Apr 16, 2020
Merged
This was referenced Apr 25, 2020
Merged
Merged
@melamity melamity mentioned this issue May 12, 2020
Merged
@anGie44 anGie44 mentioned this issue May 18, 2020
Merged
This was referenced Jun 27, 2020
Closed
Merged
Merged
@breathingdust breathingdust added the linter Pertains to changes to or issues with the various linters. label Oct 27, 2020
This was referenced Mar 24, 2021
Closed
Closed
Closed
Closed
@melamity melamity mentioned this issue Oct 26, 2021
Closed
This was referenced Feb 9, 2022
Merged
Merged
@gdavison gdavison mentioned this issue Feb 10, 2022
Merged
@melamity melamity mentioned this issue Feb 12, 2022
Merged
@melamity melamity mentioned this issue Mar 7, 2023
Open
@github-actions GitHub Actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Oct 13, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bflad @breathingdust