Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech debt: fix V001 errors in service/waf and service/wafregional #29844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

melamity
Copy link
Contributor

@melamity melamity commented Mar 7, 2023

Description

Fix V001 errors as described in the tech debt ticket #11872.

Relations

Relates #11872

References

Output from Acceptance Testing

I couldn't run these due to a WAFLimitsExceededException - unsure if I can run on my account or not, I suspect the former. 😅

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/waf Issues and PRs that pertain to the waf service. service/wafregional Issues and PRs that pertain to the wafregional service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 7, 2023
@justinretzolk justinretzolk added technical-debt Addresses areas of the codebase that need refactoring or redesign. linter Pertains to changes to or issues with the various linters. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter Pertains to changes to or issues with the various linters. service/waf Issues and PRs that pertain to the waf service. service/wafregional Issues and PRs that pertain to the wafregional service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants