Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/app_cookie_stickiness_policy - remove custom validation and replace preconfig delete #13968

Closed

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11872, #13820

Release note for CHANGELOG:

resource_aws_app_cookie_stickiness_policy: add plan time validation to `lb_port`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAppCookieStickinessPolicy_'
--- PASS: TestAccAWSAppCookieStickinessPolicy_basic (126.69s)
--- PASS: TestAccAWSAppCookieStickinessPolicy_missingLB (54.80s)
--- PASS: TestAccAWSAppCookieStickinessPolicy_disappears (65.50s)

@DrFaust92 DrFaust92 requested a review from a team June 27, 2020 08:14
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/elb Issues and PRs that pertain to the elb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 27, 2020
@DrFaust92 DrFaust92 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jun 27, 2020
@DrFaust92 DrFaust92 closed this Aug 24, 2020
@DrFaust92 DrFaust92 force-pushed the r/app_cookie_stickiness_policy branch from 0f982d8 to 116a671 Compare August 24, 2020 14:48
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 24, 2020
@ghost
Copy link

ghost commented Sep 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 23, 2020
@DrFaust92 DrFaust92 deleted the r/app_cookie_stickiness_policy branch April 15, 2021 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant