Replace PreConfig Disappears Testing

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Certain resource acceptance testing is using an older style for testing out-of-band resource deletions via PreConfig, e.g.

func TestAccAWSGlueCatalogDatabase_recreates(t *testing.T) {
	resourceName := "aws_glue_catalog_database.test"
	rName := acctest.RandomWithPrefix("tf-acc-test")

	resource.ParallelTest(t, resource.TestCase{
		PreCheck:     func() { testAccPreCheck(t) },
		Providers:    testAccProviders,
		CheckDestroy: testAccCheckGlueDatabaseDestroy,
		Steps: []resource.TestStep{
			{
				Config: testAccGlueCatalogDatabase_basic(rName),
				Check: resource.ComposeTestCheckFunc(
					testAccCheckGlueCatalogDatabaseExists(resourceName),
				),
			},
			{
				// Simulate deleting the database outside Terraform
				PreConfig: func() {
					conn := testAccProvider.Meta().(*AWSClient).glueconn
					input := &glue.DeleteDatabaseInput{
						Name: aws.String(rName),
					}
					_, err := conn.DeleteDatabase(input)
					if err != nil {
						t.Fatalf("error deleting Glue Catalog Database: %s", err)
					}
				},
				Config:             testAccGlueCatalogDatabase_basic(rName),
				ExpectNonEmptyPlan: true,
				PlanOnly:           true,
			},
		},
	})
}

This can be replaced with the easier and more consistent testAccCheckResourceDisappears() function. Example in the Contributing Guide:

func TestAccAwsExampleThing_disappears(t *testing.T) {
  rName := acctest.RandomWithPrefix("tf-acc-test")
  resourceName := "aws_example_thing.test"

  resource.ParallelTest(t, resource.TestCase{
    PreCheck:     func() { testAccPreCheck(t) },
    Providers:    testAccProviders,
    CheckDestroy: testAccCheckAwsExampleThingDestroy,
    Steps: []resource.TestStep{
      {
        Config: testAccAwsExampleThingConfigName(rName),
        Check: resource.ComposeTestCheckFunc(
          testAccCheckAwsExampleThingExists(resourceName, &job),
          testAccCheckResourceDisappears(testAccProvider, resourceAwsExampleThing(), resourceName),
        ),
        ExpectNonEmptyPlan: true,
      },
    },
  })
}

Affected Resource(s)

• aws_app_cookie_stickiness_policy
• aws_ebs_snapshot
• aws_ecs_task_definition
• aws_glue_catalog_database
• aws_glue_catalog_table
• aws_glue_crawler
• aws_lb_cookie_stickiness_policy
• aws_ssm_association

NOTE: Ignore these (we may need a different setup for this in-deletion state testing):

• TestAccAWSDBInstance_IsAlreadyBeingDeleted
• TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted

References

• https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/running-and-writing-acceptance-tests.md#disappears-acceptance-tests
• Replace testAccCheck...Disappears Implementations with testAccCheckResourceDisappears #13527

[ghost]

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!