Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/glue_catalog_database - add arn + disappears test #13452

Merged
merged 5 commits into from
Jun 23, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented May 21, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624, #13527, #13820

Release note for CHANGELOG:

resource_aws_glue_catalog_database: add arn attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSGlueCatalogDatabase_full (101.79s)
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (28.91s)

@DrFaust92 DrFaust92 requested a review from a team May 21, 2020 11:00
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 21, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 18, 2020
@bflad bflad added this to the v2.67.0 milestone Jun 18, 2020
@bflad bflad self-assigned this Jun 18, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a merge conflict (and will probably be another one with the index page when I merge #13456 so might want to wait a second), otherwise, looks good 👍

Output from acceptance testing:

--- PASS: TestAccAWSGlueCatalogDatabase_disappears (7.36s)
--- PASS: TestAccAWSGlueCatalogDatabase_recreates (9.78s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (20.10s)

aws/resource_aws_glue_catalog_database.go Show resolved Hide resolved
@DrFaust92 DrFaust92 force-pushed the r/glue_catalog_database-arn branch from 29f9489 to 4489878 Compare June 18, 2020 09:14
@DrFaust92 DrFaust92 force-pushed the r/glue_catalog_database-arn branch from 4489878 to 318d48c Compare June 18, 2020 10:35
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jun 18, 2020
@DrFaust92 DrFaust92 requested a review from bflad June 18, 2020 10:38
@DrFaust92 DrFaust92 requested a review from bflad June 18, 2020 10:55
@breathingdust breathingdust modified the milestones: v2.67.0, v2.68.0 Jun 18, 2020
@DrFaust92
Copy link
Collaborator Author

added change for #13820

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAWSGlueCatalogDatabase_disappears (6.32s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (18.52s)

@bflad bflad merged commit c123693 into hashicorp:master Jun 23, 2020
bflad added a commit that referenced this pull request Jun 23, 2020
@DrFaust92 DrFaust92 deleted the r/glue_catalog_database-arn branch June 23, 2020 11:10
@ghost
Copy link

ghost commented Jun 26, 2020

This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants