Fix and enable tfproviderlint R006 check: RetryFunc should include RetryableError() handling or RetryFunc should be removed #11864

bflad · 2020-02-03T21:24:06Z

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

RetryFunc should only be used in retry logic. See also: https://github.com/bflad/tfproviderlint/blob/master/passes/R006/README.md

e.g.

/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_codedeploy_deployment_group.go:553:38: R006: RetryFunc should include RetryableError() handling or be removed
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_codedeploy_deployment_group.go:733:38: R006: RetryFunc should include RetryableError() handling or be removed
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_policy_attachment.go:220:53: R006: RetryFunc should include RetryableError() handling or be removed
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lambda_permission.go:339:38: R006: RetryFunc should include RetryableError() handling or be removed
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_redshift_snapshot_copy_grant.go:274:38: R006: RetryFunc should include RetryableError() handling or be removed
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sfn_activity.go:117:39: R006: RetryFunc should include RetryableError() handling or be removed
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sfn_state_machine.go:181:39: R006: RetryFunc should include RetryableError() handling or be removed
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ssm_document.go:213:39: R006: RetryFunc should include RetryableError() handling or be removed

Definition of Done

Fix R006 reports
In GNUmakefile, add -R006 to tfproviderlint command under lint target and have TravisCI testing pass

The text was updated successfully, but these errors were encountered:

Gaps in `tfproviderlint` checking are covered by the following issues: Reference: #9950 (fix and enable AT003) Reference: #11862 (fix and enable AT005) Reference: #9951 (fix and enable R001) Reference: #9952 (fix and enable R002) Reference: #9953 (fix and enable R003) Reference: #9954 (fix and enable R004) Reference: #11863 (fix and enable R005) Reference: #11864 (fix and enable R006) Reference: #9955 (fix and enable S006) Reference: #9956 (fix and enable S018) Reference: #11865 (fix and enable S020) Reference: #11866 (fix and enable S022) Reference: #11867 (fix and enable S023) Reference: #11868 (fix and enable S024) Reference: #11869 (fix and enable S031) Reference: #11870 (fix and enable S032) Reference: #11871 (fix and enable S033) Reference: #11872 (fix and enable V001) Reference: #11844 (fix and enable V002, V004, V005, V007, V008)

Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. This particular case is a false positive, but does indicate this resource is not following the current practice of inlining the error handling in this retry function. Another option here would be to have the retryable error checking as a boolean returning function, in which the `RetryFunc` triggers `return resource.RetryableError(err)`. Previously: ``` aws/resource_aws_codedeploy_deployment_group.go:554:38: R006: RetryFunc should include RetryableError() handling or be removed aws/resource_aws_codedeploy_deployment_group.go:734:38: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (34.18s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (43.48s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (51.83s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (70.71s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (36.35s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (49.34s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (59.52s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (45.27s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (63.68s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (53.52s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (50.69s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (166.59s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (59.43s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (48.95s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg (173.58s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (51.83s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (47.18s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (60.90s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (74.54s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (44.40s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen (318.29s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_create (30.55s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_update (68.76s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (44.55s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (40.08s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (28.30s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (37.85s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (42.57s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (56.71s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (31.77s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (43.51s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (59.76s) ```

Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. This particular case looks like the original intent was to verify via read-after-write that the appropriate write was persisted, however the logic errantly returned `return resource.NonRetryableError()` with `nil` when the role policy was not found, ending the `RetryFunc` without an actual error and never retrying on any condition. Previously: ``` aws/resource_aws_iam_policy_attachment.go:220:53: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSIAMPolicyAttachment_Groups_RenamedGroup (22.54s) --- PASS: TestAccAWSIAMPolicyAttachment_Users_RenamedUser (23.00s) --- PASS: TestAccAWSIAMPolicyAttachment_Roles_RenamedRole (24.95s) --- PASS: TestAccAWSIAMPolicyAttachment_basic (39.85s) --- PASS: TestAccAWSIAMPolicyAttachment_paginatedEntities (242.04s) ```

Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. In this particular case, the code had no retryable conditions, so the retry logic was extraneous. It is worth noting that this type of delete-then-check code in a Terraform resource is very uncommon and likely should be removed, although there is a note at the top of the deletion function that mentions an acknowledged API bug with parallel requests so leaving this in here for now. Previously: ``` aws/resource_aws_lambda_permission.go:339:38: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSLambdaPermission_withS3 (55.05s) --- PASS: TestAccAWSLambdaPermission_withSNS (60.76s) --- PASS: TestAccAWSLambdaPermission_basic (67.48s) --- PASS: TestAccAWSLambdaPermission_withRawFunctionName (79.46s) --- PASS: TestAccAWSLambdaPermission_withIAMRole (86.26s) --- PASS: TestAccAWSLambdaPermission_multiplePerms (92.22s) --- PASS: TestAccAWSLambdaPermission_withStatementIdPrefix (93.41s) --- PASS: TestAccAWSLambdaPermission_withQualifier (100.65s) --- PASS: TestAccAWSLambdaPermission_StatementId_Duplicate (102.96s) ```

Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. Previously: ``` aws/resource_aws_redshift_snapshot_copy_grant.go:274:38: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (15.81s) --- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (38.59s) ```

Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. Previously: ``` aws/resource_aws_ssm_document.go:213:39: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSSSMDocument_basic (26.29s) --- PASS: TestAccAWSSSMDocument_session (37.24s) --- PASS: TestAccAWSSSMDocument_automation (41.32s) --- PASS: TestAccAWSSSMDocument_permission_batching (44.07s) --- PASS: TestAccAWSSSMDocument_params (46.96s) --- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (48.76s) --- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (51.32s) --- PASS: TestAccAWSSSMDocument_target_type (51.87s) --- PASS: TestAccAWSSSMDocument_Tags (58.75s) --- PASS: TestAccAWSSSMDocument_permission_private (66.11s) --- PASS: TestAccAWSSSMDocument_permission_public (67.63s) --- PASS: TestAccAWSSSMDocument_update (76.88s) --- PASS: TestAccAWSSSMDocument_permission_change (77.82s) --- PASS: TestAccAWSSSMDocument_package (83.33s) ```

Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. Previously: ``` aws/resource_aws_sfn_activity.go:117:39: R006: RetryFunc should include RetryableError() handling or be removed aws/resource_aws_sfn_state_machine.go:181:39: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing (unrelated failure present on master due to SFN eventual consistency): ``` --- PASS: TestAccAWSSfnActivity_basic (18.37s) --- PASS: TestAccAWSSfnActivity_Tags (43.33s) --- FAIL: TestAccAWSSfnStateMachine_createUpdate (55.52s) testing.go:640: Step 1 error: Check failed: Check 5/6 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n \"StartAt\": \"HelloWorld\",\n \"States\": {\n \"HelloWorld\": {\n \"Type\": \"Task\",\n \"Resource\": \"arn:aws:lambda:us-west-2:187416307283:function:sfn-uzt6w9nxeb\",\n \"Retry\": [\n {\n \"ErrorEquals\": [\"States.ALL\"],\n \"IntervalSeconds\": 5,\n \"MaxAttempts\": 5,\n \"BackoffRate\": 8.0\n }\n ],\n \"End\": true\n }\n }\n}\n" --- PASS: TestAccAWSSfnStateMachine_Tags (73.52s) ```

Reference: #11864

Reference: #12074 Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues: Reference: #11888 (fix and enable AWSAT001) Reference: #9950 (fix and enable AT003) Reference: #11862 (fix and enable AT005) Reference: #9951 (fix and enable R001) Reference: #9952 (fix and enable R002) Reference: #9953 (fix and enable R003) Reference: #11863 (fix and enable R005) Reference: #11864 (fix and enable R006) Reference: #12083 (fix and enable R007, R008) Reference: #9955 (fix and enable S006) Reference: #9956 (fix and enable S018) Reference: #11865 (fix and enable S020) Reference: #11866 (fix and enable S022) Reference: #11867 (fix and enable S023) Reference: #11868 (fix and enable S024) Reference: #11869 (fix and enable S031) Reference: #11870 (fix and enable S032) Reference: #11871 (fix and enable S033) Reference: #11872 (fix and enable V001) Reference: #11844 (fix and enable V002, V004, V005, V007, V008)

Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. Previously: ``` aws/resource_aws_sfn_activity.go:117:39: R006: RetryFunc should include RetryableError() handling or be removed aws/resource_aws_sfn_state_machine.go:181:39: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing (unrelated failure present on master due to SFN eventual consistency): ``` --- PASS: TestAccAWSSfnActivity_basic (18.37s) --- PASS: TestAccAWSSfnActivity_Tags (43.33s) --- FAIL: TestAccAWSSfnStateMachine_createUpdate (55.52s) testing.go:640: Step 1 error: Check failed: Check 5/6 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n \"StartAt\": \"HelloWorld\",\n \"States\": {\n \"HelloWorld\": {\n \"Type\": \"Task\",\n \"Resource\": \"arn:aws:lambda:us-west-2:187416307283:function:sfn-uzt6w9nxeb\",\n \"Retry\": [\n {\n \"ErrorEquals\": [\"States.ALL\"],\n \"IntervalSeconds\": 5,\n \"MaxAttempts\": 5,\n \"BackoffRate\": 8.0\n }\n ],\n \"End\": true\n }\n }\n}\n" --- PASS: TestAccAWSSfnStateMachine_Tags (73.52s) ```

Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. Previously: ``` aws/resource_aws_ssm_document.go:213:39: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSSSMDocument_basic (26.29s) --- PASS: TestAccAWSSSMDocument_session (37.24s) --- PASS: TestAccAWSSSMDocument_automation (41.32s) --- PASS: TestAccAWSSSMDocument_permission_batching (44.07s) --- PASS: TestAccAWSSSMDocument_params (46.96s) --- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (48.76s) --- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (51.32s) --- PASS: TestAccAWSSSMDocument_target_type (51.87s) --- PASS: TestAccAWSSSMDocument_Tags (58.75s) --- PASS: TestAccAWSSSMDocument_permission_private (66.11s) --- PASS: TestAccAWSSSMDocument_permission_public (67.63s) --- PASS: TestAccAWSSSMDocument_update (76.88s) --- PASS: TestAccAWSSSMDocument_permission_change (77.82s) --- PASS: TestAccAWSSSMDocument_package (83.33s) ```

…006 (#12045) Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. Previously: ``` aws/resource_aws_redshift_snapshot_copy_grant.go:274:38: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (15.81s) --- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (38.59s) ```

Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. In this particular case, the code had no retryable conditions, so the retry logic was extraneous. It is worth noting that this type of delete-then-check code in a Terraform resource is very uncommon and likely should be removed, although there is a note at the top of the deletion function that mentions an acknowledged API bug with parallel requests so leaving this in here for now. Previously: ``` aws/resource_aws_lambda_permission.go:339:38: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSLambdaPermission_withS3 (55.05s) --- PASS: TestAccAWSLambdaPermission_withSNS (60.76s) --- PASS: TestAccAWSLambdaPermission_basic (67.48s) --- PASS: TestAccAWSLambdaPermission_withRawFunctionName (79.46s) --- PASS: TestAccAWSLambdaPermission_withIAMRole (86.26s) --- PASS: TestAccAWSLambdaPermission_multiplePerms (92.22s) --- PASS: TestAccAWSLambdaPermission_withStatementIdPrefix (93.41s) --- PASS: TestAccAWSLambdaPermission_withQualifier (100.65s) --- PASS: TestAccAWSLambdaPermission_StatementId_Duplicate (102.96s) ```

…2043) Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. This particular case looks like the original intent was to verify via read-after-write that the appropriate write was persisted, however the logic errantly returned `return resource.NonRetryableError()` with `nil` when the role policy was not found, ending the `RetryFunc` without an actual error and never retrying on any condition. Previously: ``` aws/resource_aws_iam_policy_attachment.go:220:53: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSIAMPolicyAttachment_Groups_RenamedGroup (22.54s) --- PASS: TestAccAWSIAMPolicyAttachment_Users_RenamedUser (23.00s) --- PASS: TestAccAWSIAMPolicyAttachment_Roles_RenamedRole (24.95s) --- PASS: TestAccAWSIAMPolicyAttachment_basic (39.85s) --- PASS: TestAccAWSIAMPolicyAttachment_paginatedEntities (242.04s) ```

…06 (#12042) Reference: #11864 `RetryFunc` should only be used when logic has a retryable condition. In the case of working with the AWS Go SDK, it also arbitrarily restricts the automatic retrying logic of API calls to the timeout, which is generally undesired. This particular case is a false positive, but does indicate this resource is not following the current practice of inlining the error handling in this retry function. Another option here would be to have the retryable error checking as a boolean returning function, in which the `RetryFunc` triggers `return resource.RetryableError(err)`. Previously: ``` aws/resource_aws_codedeploy_deployment_group.go:554:38: R006: RetryFunc should include RetryableError() handling or be removed aws/resource_aws_codedeploy_deployment_group.go:734:38: R006: RetryFunc should include RetryableError() handling or be removed ``` Output from acceptance testing: ``` --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (34.18s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (43.48s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (51.83s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (70.71s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (36.35s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (49.34s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (59.52s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (45.27s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (63.68s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (53.52s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (50.69s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (166.59s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (59.43s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (48.95s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg (173.58s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (51.83s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (47.18s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (60.90s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (74.54s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (44.40s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen (318.29s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_create (30.55s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_update (68.76s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (44.55s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (40.08s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (28.30s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (37.85s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (42.57s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (56.71s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (31.77s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (43.51s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (59.76s) ```

Reference: #11864

ghost · 2020-02-28T14:37:09Z

This has been released in version 2.51.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

Reference: #12074 Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues: Reference: #11888 (fix and enable AWSAT001) Reference: #9950 (fix and enable AT003) Reference: #11862 (fix and enable AT005) Reference: #9951 (fix and enable R001) Reference: #9952 (fix and enable R002) Reference: #9953 (fix and enable R003) Reference: #11863 (fix and enable R005) Reference: #11864 (fix and enable R006) Reference: #12083 (fix and enable R007, R008) Reference: #9955 (fix and enable S006) Reference: #9956 (fix and enable S018) Reference: #11865 (fix and enable S020) Reference: #11866 (fix and enable S022) Reference: #11867 (fix and enable S023) Reference: #11868 (fix and enable S024) Reference: #11869 (fix and enable S031) Reference: #11870 (fix and enable S032) Reference: #11871 (fix and enable S033) Reference: #11872 (fix and enable V001) Reference: #11844 (fix and enable V002, V004, V005, V007, V008)

ghost · 2020-03-22T14:50:30Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Feb 3, 2020

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 3, 2020

bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 3, 2020

bflad mentioned this issue Feb 3, 2020

tests/provider: Enable new passing tfproviderlint checks #11873

Merged

bflad mentioned this issue Feb 7, 2020

aws_route53_record: add create,update,delete timeout options for the resource #11895

Merged

bflad self-assigned this Feb 12, 2020

bflad mentioned this issue Feb 13, 2020

resource/aws_codedeploy_deployment_group: Fixes for tfproviderlint R006 #12042

Merged

bflad mentioned this issue Feb 13, 2020

resource/aws_iam_policy_attachment: Fixes for tfproviderlint R006 #12043

Merged

bflad mentioned this issue Feb 13, 2020

resource/aws_lambda_permission: Fixes for tfproviderlint R006 #12044

Merged

bflad mentioned this issue Feb 13, 2020

resource/aws_redshift_snapshot_copy_grant: Fixes for tfproviderlint R006 #12045

Merged

bflad mentioned this issue Feb 13, 2020

resource/aws_ssm_document: Fixes for tfproviderlint R006 #12046

Merged

bflad mentioned this issue Feb 13, 2020

service/sfn: Fixes for tfproviderlint R006 #12047

Merged

bflad added a commit that referenced this issue Feb 13, 2020

tests/provider: Enable tfproviderlint R006 check

c28facf

Reference: #11864

bflad mentioned this issue Feb 13, 2020

tests/provider: Enable tfproviderlint R006 check #12048

Merged

6 tasks

bflad mentioned this issue Feb 19, 2020

tests/provider: Enable passing tfproviderlint v0.10.0 checks #12088

Merged

bflad added a commit that referenced this issue Feb 20, 2020

tests/provider: Enable tfproviderlint R006 check

5a6db44

Reference: #11864

bflad closed this as completed in #12048 Feb 21, 2020

bflad added a commit that referenced this issue Feb 21, 2020

tests/provider: Enable tfproviderlint R006 check (#12048)

addd865

Reference: #11864

bflad added this to the v2.51.0 milestone Feb 21, 2020

fmasuhr mentioned this issue Mar 12, 2020

Fix tfproviderlint checks babbel/terraform-provider-aws#16

Merged

ghost locked and limited conversation to collaborators Mar 22, 2020

breathingdust added the linter Pertains to changes to or issues with the various linters. label Oct 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix and enable tfproviderlint R006 check: RetryFunc should include RetryableError() handling or RetryFunc should be removed #11864

Fix and enable tfproviderlint R006 check: RetryFunc should include RetryableError() handling or RetryFunc should be removed #11864

bflad commented Feb 3, 2020

ghost commented Feb 28, 2020

ghost commented Mar 22, 2020

Fix and enable tfproviderlint R006 check: RetryFunc should include RetryableError() handling or RetryFunc should be removed #11864

Fix and enable tfproviderlint R006 check: RetryFunc should include RetryableError() handling or RetryFunc should be removed #11864

Comments

bflad commented Feb 3, 2020

Community Note

Description

Definition of Done

ghost commented Feb 28, 2020

ghost commented Mar 22, 2020