Skip to content
This repository has been archived by the owner on Dec 9, 2020. It is now read-only.

Fix tfproviderlint checks #16

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Fix tfproviderlint checks #16

merged 2 commits into from
Mar 12, 2020

Conversation

fmasuhr
Copy link
Member

@fmasuhr fmasuhr commented Mar 12, 2020 •
edited
Loading

The tfproviderlint is not enabled to check (hashicorp#11864) on this odd behavior of using retry for responses which never return a RetryableError. https://github.com/bflad/tfproviderlint/blob/master/passes/R006/README.md
Therefore dropping the retry completely here.

The send part is about S033 of tfproviderlint which requires the StateFunc to not be present for computed attributes.

@fmasuhr fmasuhr requested review from awendt, jansiwy and jtsaito March 12, 2020 12:48
@fmasuhr fmasuhr self-assigned this Mar 12, 2020
@fmasuhr fmasuhr changed the title no retry on NonRetryableErrors for opsworks permissions Fix tfproviderlint checks Mar 12, 2020
jtsaito
jtsaito approved these changes Mar 12, 2020
View reviewed changes
Copy link

@jtsaito jtsaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not particularly confident about the skipping Retry but I guess worst case the plan will fail a bit more often.

@fmasuhr fmasuhr merged commit 833bd6f into master Mar 12, 2020
@fmasuhr fmasuhr deleted the opsworks-retry branch March 12, 2020 15:20
@fmasuhr
Copy link
Member Author

fmasuhr commented Mar 13, 2020

Update terraform AWS provider

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtsaito jtsaito jtsaito approved these changes

@jansiwy jansiwy jansiwy approved these changes

@awendt awendt Awaiting requested review from awendt

Assignees

@fmasuhr fmasuhr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmasuhr @jansiwy @jtsaito