Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module bflad/tfproviderlint to v0.10.0 #12074

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 18, 2020

This PR contains the following updates:

Package Type Update Change
github.com/bflad/tfproviderlint require minor v0.9.0 -> v0.10.0

Release Notes

bflad/tfproviderlint

v0.10.0

Compare Source

BREAKING CHANGES

  • helper/terraformtype/helper/schema: NewSchemaValidateFuncInfo now accepts a single ast.Node instead of separate *ast.FuncDecl and *ast.FuncLit

FEATURES

  • New Check: AT008: check for acceptance test function declaration *testing.T parameter naming
  • New Check: R007: check for deprecated (schema.ResourceData).Partial receiver method usage
  • New Check: R008: check for deprecated (schema.ResourceData).SetPartial receiver method usage
  • New Check: R009: check for Go panic usage
  • New Check: R010: check for (schema.ResourceData).GetChange assignment which should use (schema.ResourceData).Get
  • New Check: R011: check for Resource that configure MigrateState
  • New Check: R012: check for data source Resource that configure CustomizeDiff
  • New Check: R013: check for map[string]*Resource that resource names contain at least one underscore
  • New Check: R014: check for CreateFunc, DeleteFunc, ReadFunc, and UpdateFunc parameter naming
  • New Check: S034: check for Schema that configure PromoteSingle

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you tick the rebase/retry checkbox below.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team February 18, 2020 13:49
@renovate renovate bot added the dependencies Used to indicate dependency changes. label Feb 18, 2020
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XXL Managed by automation to categorize the size of a PR. labels Feb 18, 2020
@bflad bflad added provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 18, 2020
@bflad bflad self-assigned this Feb 18, 2020
@bflad
Copy link
Contributor

bflad commented Feb 18, 2020

Dependent on #12012 acceptance testing

@renovate renovate bot force-pushed the renovate/github.com-bflad-tfproviderlint-0.x branch from 22c0598 to 701e517 Compare February 19, 2020 14:55
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging per maintaining guide as it passes CI. Will separately investigate the new checks to create issues for any failures and a PR to enable all passing checks.

@bflad bflad added this to the v2.50.0 milestone Feb 19, 2020
@bflad bflad merged commit d67a26f into master Feb 19, 2020
@bflad bflad deleted the renovate/github.com-bflad-tfproviderlint-0.x branch February 19, 2020 15:20
bflad added a commit that referenced this pull request Feb 19, 2020
Reference: #12074

Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues:

Reference: #11888 (fix and enable AWSAT001)
Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #12083 (fix and enable R007, R008)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
@ghost
Copy link

ghost commented Feb 21, 2020

This has been released in version 2.50.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

bflad added a commit that referenced this pull request Mar 10, 2020
Reference: #12074

Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues:

Reference: #11888 (fix and enable AWSAT001)
Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #12083 (fix and enable R007, R008)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants