Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/worklink: tech debt: fix V001 linter errors #23089

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

melamity
Copy link
Contributor

@melamity melamity commented Feb 9, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11872

Output from acceptance testing:

I couldn't run the acceptance tests. Despite having the full admin role on the IAM API key, it said I had no permission. I assume something bigger is involved here. My apologies.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. service/worklink Issues and PRs that pertain to the worklink service. labels Feb 9, 2022
@gdavison gdavison self-assigned this Feb 10, 2022
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- PASS: TestAccWorkLinkFleet_deviceCaCertificate (81.28s)
--- PASS: TestAccWorkLinkFleet_disappears (82.10s)
--- PASS: TestAccWorkLinkFleet_identityProvider (82.57s)
--- PASS: TestAccWorkLinkFleet_displayName (85.80s)
--- PASS: TestAccWorkLinkFleet_optimizeForEndUserLocation (89.07s)
--- PASS: TestAccWorkLinkFleet_basic (90.09s)
--- PASS: TestAccWorkLinkFleet_auditStreamARN (90.22s)

@gdavison gdavison merged commit f45acbb into hashicorp:main Feb 10, 2022
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Feb 10, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 10, 2022
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/worklink Issues and PRs that pertain to the worklink service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants