Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/organizations_account: tech debt: replace custom validation funcs #13291

Merged
merged 1 commit into from
May 13, 2020
Merged

r/organizations_account: tech debt: replace custom validation funcs #13291

merged 1 commit into from
May 13, 2020

Conversation

megubyte
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11872

Release note for CHANGELOG:

NONE

Output from acceptance testing:

Couldn't seem to run the acceptance tests for this.

@megubyte megubyte requested a review from a team May 12, 2020 19:11
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/organizations Issues and PRs that pertain to the organizations service. labels May 12, 2020
@anGie44 anGie44 added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels May 12, 2020
@anGie44 anGie44 self-assigned this May 13, 2020
anGie44
anGie44 approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @megubyte for this PR, LGTM 👍 no worries about the acceptance tests -- these organizations acceptance tests seem to all live in one test file, with TestAccAWSOrganizations/Account as a sub-suite of tests

output of acceptance tests:

--- PASS: TestAccAWSOrganizations (15.63s)

@anGie44 anGie44 requested a review from bflad May 13, 2020 15:11
bflad
bflad approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anGie44 anGie44 merged commit 1fb5324 into hashicorp:master May 13, 2020
@megubyte megubyte deleted the v001-check/r-organizations-account branch May 14, 2020 08:09
@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
service/organizations Issues and PRs that pertain to the organizations service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@megubyte @bflad @anGie44