service/cloudwatch: tech debt: replace custom validation funcs

[melamity]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11872

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccCloudWatch' PKG_NAME=internal/services/cloudwatch
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (42.47s)
--- PASS: TestAccCloudWatchMetricStream_namePrefix (66.72s)
--- PASS: TestAccCloudWatchCompositeAlarm_basic (75.11s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (31.84s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (135.34s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (135.95s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (139.50s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (147.34s)
--- PASS: TestAccCloudWatchMetricStream_tags (148.08s)
--- PASS: TestAccCloudWatchMetricStream_excludeFilters (148.21s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (148.26s)
--- PASS: TestAccCloudWatchMetricStream_noName (148.51s)
--- PASS: TestAccCloudWatchMetricStream_includeFilters (155.81s)
--- PASS: TestAccCloudWatchDashboard_updateName (125.90s)
--- PASS: TestAccCloudWatchCompositeAlarm_updateAlarmRule (171.08s)
--- PASS: TestAccCloudWatchDashboard_basic (36.58s)
--- PASS: TestAccCloudWatchCompositeAlarm_description (172.65s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (99.24s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (189.71s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (97.24s)
--- PASS: TestAccCloudWatchCompositeAlarm_disappears (57.65s)
--- PASS: TestAccCloudWatchMetricStream_update (211.86s)
--- PASS: TestAccCloudWatchDashboard_update (73.96s)
--- PASS: TestAccCloudWatchCompositeAlarm_actionsEnabled (87.83s)
--- PASS: TestAccCloudWatchCompositeAlarm_allActions (87.93s)
--- PASS: TestAccCloudWatchCompositeAlarm_okActions (89.85s)
--- PASS: TestAccCloudWatchMetricStream_basic (247.50s)
--- PASS: TestAccCloudWatchCompositeAlarm_alarmActions (111.85s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (252.90s)
--- PASS: TestAccCloudWatchCompositeAlarm_insufficientDataActions (110.60s)
--- PASS: TestAccCloudWatchMetricStream_updateName (302.91s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (397.74s)

Nice to be back working on some of the linter technical debt again - no doubt more might need doing than last time I looked, so using the output of make providerlint to track down changes for future PRs.

[melamity]

I'm aware of the failing test and will return with a version that is not failing in the CI later.

[melamity]

The failing test is a weird one: we consider a "" string to be valid (as in, length of zero) but in terms of consistency... this doesn't match what other validators are doing - maybe it's something to look in to sometime, but for the time being I made them pass.

[github-actions]

Marking this pull request as stale due to inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.