r/elastic_transcoder_preset - allow setting audio.bit_rate to null + add validations

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13527
Closes #14090
Closes #22362

Release note for CHANGELOG:

resource_aws_elastic_transcoder_preset: add plan time validations for `audio.audio_packing_mode`,  `audio.channels`,
`audio.codec`,`audio.sample_rate`, `audio_codec_options.bit_depth`, `audio_codec_options.bit_order`,
`audio_codec_options.profile`, `audio_codec_options.signed`, `audio_codec_options.signed`, 
`container`, `thumbnails.aspect_ratio`, `thumbnails.format`, `thumbnails.padding_policy`, `thumbnails.sizing_policy`,
`type`, `video.aspect_ratio`, `video.codec`, `video.display_aspect_ratio`, `video.fixed_gop`, `video.frame_rate`,   `video.max_frame_rate`,  `video.padding_policy`, `video.sizing_policy`, `video_watermarks.horizontal_align`, 
`video_watermarks.id`, `video_watermarks.sizing_policy`, `video_watermarks.target`, `video_watermarks.vertical_align`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticTranscoderPreset_'
--- PASS: TestAccElasticTranscoderPreset_disappears (70.27s)
--- PASS: TestAccElasticTranscoderPreset_audio_noBitRate (89.56s)
--- PASS: TestAccElasticTranscoderPreset_AudioCodecOptions_empty (89.66s)
--- PASS: TestAccElasticTranscoderPreset_basic (89.77s)
--- PASS: TestAccElasticTranscoderPreset_Video_frameRate (89.85s)
--- PASS: TestAccElasticTranscoderPreset_video_noCodec (93.64s)
--- PASS: TestAccElasticTranscoderPreset_description (97.92s)
--- PASS: TestAccElasticTranscoderPreset_full (166.30s)

[mgzenitech]

So anyone will ever look into this PR? Without this change, lossless audio presets for Elastic Transcoder are impossible to set up

[DrFaust92]

Resolved Conflict

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccElasticTranscoderPreset_' PKG=elastictranscoder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elastictranscoder/... -v -count 1 -parallel 20  -run=TestAccElasticTranscoderPreset_ -timeout 180m
=== RUN   TestAccElasticTranscoderPreset_basic
=== PAUSE TestAccElasticTranscoderPreset_basic
=== RUN   TestAccElasticTranscoderPreset_video_noCodec
=== PAUSE TestAccElasticTranscoderPreset_video_noCodec
=== RUN   TestAccElasticTranscoderPreset_audio_noBitRate
=== PAUSE TestAccElasticTranscoderPreset_audio_noBitRate
=== RUN   TestAccElasticTranscoderPreset_disappears
=== PAUSE TestAccElasticTranscoderPreset_disappears
=== RUN   TestAccElasticTranscoderPreset_AudioCodecOptions_empty
=== PAUSE TestAccElasticTranscoderPreset_AudioCodecOptions_empty
=== RUN   TestAccElasticTranscoderPreset_description
=== PAUSE TestAccElasticTranscoderPreset_description
=== RUN   TestAccElasticTranscoderPreset_full
=== PAUSE TestAccElasticTranscoderPreset_full
=== RUN   TestAccElasticTranscoderPreset_Video_frameRate
=== PAUSE TestAccElasticTranscoderPreset_Video_frameRate
=== CONT  TestAccElasticTranscoderPreset_basic
=== CONT  TestAccElasticTranscoderPreset_full
=== CONT  TestAccElasticTranscoderPreset_AudioCodecOptions_empty
=== CONT  TestAccElasticTranscoderPreset_disappears
=== CONT  TestAccElasticTranscoderPreset_description
=== CONT  TestAccElasticTranscoderPreset_Video_frameRate
=== CONT  TestAccElasticTranscoderPreset_audio_noBitRate
=== CONT  TestAccElasticTranscoderPreset_video_noCodec
--- PASS: TestAccElasticTranscoderPreset_disappears (22.77s)
--- PASS: TestAccElasticTranscoderPreset_description (25.54s)
--- PASS: TestAccElasticTranscoderPreset_audio_noBitRate (28.79s)
--- PASS: TestAccElasticTranscoderPreset_AudioCodecOptions_empty (28.79s)
--- PASS: TestAccElasticTranscoderPreset_video_noCodec (28.80s)
--- PASS: TestAccElasticTranscoderPreset_Video_frameRate (28.82s)
--- PASS: TestAccElasticTranscoderPreset_basic (31.36s)
--- PASS: TestAccElasticTranscoderPreset_full (44.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder	50.581s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.