service/redshift: tech debt: replace existing custom validators

[melamity]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11872

Release note for CHANGELOG:

NONE

Output from acceptance testing:

--- PASS: TestAccAWSRedshiftCluster_basic (480.63s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (581.99s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (588.98s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (630.36s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (573.39s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (499.57s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (709.97s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (513.95s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1268.92s)
--- PASS: TestAccAWSRedshiftCluster_tags (526.38s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (2903.58s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (1126.08s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (2334.93s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2411.30s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (2110.03s)

--- PASS: TestAccAWSRedshiftParameterGroup_withParameters (31.75s)
--- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (32.38s)
--- PASS: TestAccAWSRedshiftParameterGroup_basic (32.49s)
--- PASS: TestAccAWSRedshiftParameterGroup_withTags (72.25s)

--- PASS: TestAccAWSRedshiftSubnetGroup_basic (57.09s)
--- PASS: TestAccAWSRedshiftSubnetGroup_tags (93.79s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateDescription (96.07s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (98.98s)

NB: Could not run EC2 Classic (Redshift Security Group) acceptance tests, AWS account was made after 2013-12-04.

[anGie44]

hi @megubyte, thank you for continuing the tech debt effort with this PR! the updated validation functions look great, only comments re: adding test coverage as something to consider. now looking more into the usage, I'd expect the validation functions are already unit tested so may just be a nice-to-have in this context

Update: asked internally about the validation tests and found it's not needed here so this LGTM overall 👍

[anGie44]

Output of acceptance tests:

PASS: TestAccAWSRedshiftCluster_*
PASS: TestAccAWSRedshiftParameterGroup_*
PASS: TestAccAWSRedshiftSecurityGroup_*
PASS: TestAccAWSRedshiftSubnetGroup_*

With exception of the following tests failing in CI which have a track-record of timing out:

TestAccAWSRedshiftCluster_publiclyAccessible
TestAccAWSRedshiftCluster_updateNodeCount
TestAccAWSRedshiftCluster_updateNodeType

[bflad]

LGTM, acceptance testing is good except for the unrelated timeout issues that I'm also seeing.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!