Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/ssm: tech debt: fix V001 errors #23082

Merged
merged 2 commits into from
Feb 9, 2022
Merged

service/ssm: tech debt: fix V001 errors #23082

merged 2 commits into from
Feb 9, 2022

Conversation

melamity
Copy link
Contributor

@melamity melamity commented Feb 9, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11872

Output from acceptance testing:

TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSM -timeout 180m
--- PASS: TestAccSSMPatchBaselineDataSource_existingBaseline (67.05s)
--- PASS: TestAccSSMParametersByPathDataSource_basic (75.51s)
--- PASS: TestAccSSMParameter_secure (77.12s)
--- PASS: TestAccSSMPatchBaselineDataSource_newBaseline (78.07s)
--- PASS: TestAccSSMParametersByPathDataSource_withRecursion (78.98s)
--- PASS: TestAccSSMMaintenanceWindowTask_disappears (80.47s)
--- PASS: TestAccSSMMaintenanceWindowTask_emptyNotification (80.55s)
--- PASS: TestAccSSMParameter_fullPath (80.67s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters (85.95s)
--- PASS: TestAccSSMParameter_DataType_awsEC2Image (92.82s)
--- PASS: TestAccSSMParameter_secureWithKey (94.99s)
--- PASS: TestAccSSMActivation_basic (95.69s)
--- PASS: TestAccSSMParameterDataSource_basic (97.21s)
--- PASS: TestAccSSMPatchBaseline_basic (100.16s)
--- PASS: TestAccSSMParameter_updateType (104.53s)
--- PASS: TestAccSSMMaintenanceWindowTarget_validation (12.88s)
--- PASS: TestAccSSMParameter_changeNameForcesNew (107.93s)
--- PASS: TestAccSSMParameter_Secure_keyUpdate (116.15s)
--- PASS: TestAccSSMDocument_disappears (34.65s)
--- PASS: TestAccSSMPatchBaseline_tags (120.61s)
--- PASS: TestAccSSMParameter_updateDescription (60.67s)
--- PASS: TestAccSSMMaintenanceWindowTarget_basic (47.23s)
--- PASS: TestAccSSMMaintenanceWindowTarget_noNameOrDescription (48.94s)
--- PASS: TestAccSSMDocument_Permission_change (134.84s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch (136.93s)
--- PASS: TestAccSSMMaintenanceWindow_scheduleOffset (66.39s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters (75.75s)
--- PASS: TestAccSSMMaintenanceWindowTask_noRole (36.68s)
--- PASS: TestAccSSMMaintenanceWindowTarget_Disappears_window (27.13s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters (87.85s)
--- PASS: TestAccSSMMaintenanceWindow_schedule (66.60s)
--- PASS: TestAccSSMMaintenanceWindow_duration (57.33s)
--- PASS: TestAccSSMMaintenanceWindowTask_description (70.40s)
--- PASS: TestAccSSMMaintenanceWindow_startDate (90.00s)
--- PASS: TestAccSSMMaintenanceWindow_scheduleTimezone (88.49s)
--- PASS: TestAccSSMMaintenanceWindow_enabled (63.53s)
--- PASS: TestAccSSMDocument_session (41.51s)
--- PASS: TestAccSSMMaintenanceWindowTask_updateForcesNewResource (71.47s)
--- PASS: TestAccSSMMaintenanceWindow_cutoff (55.83s)
--- PASS: TestAccSSMMaintenanceWindow_disappears (25.32s)
--- PASS: TestAccSSMMaintenanceWindowTarget_disappears (31.94s)
--- PASS: TestAccSSMMaintenanceWindow_endDate (84.57s)
--- PASS: TestAccSSMMaintenanceWindow_multipleUpdates (52.57s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters (97.60s)
--- PASS: TestAccSSMDocument_DocumentFormat_yaml (66.62s)
--- PASS: TestAccSSMMaintenanceWindowTask_basic (70.65s)
--- PASS: TestAccSSMDocument_tags (83.80s)
--- PASS: TestAccSSMMaintenanceWindowTarget_resourceGroup (50.05s)
--- PASS: TestAccSSMMaintenanceWindow_basic (50.93s)
--- PASS: TestAccSSMDocument_SchemaVersion_1 (62.20s)
--- PASS: TestAccSSMDocument_params (48.61s)
--- PASS: TestAccSSMDocument_Permission_public (56.95s)
--- PASS: TestAccSSMDocument_Permission_private (57.75s)
--- PASS: TestAccSSMDocument_Permission_batching (60.15s)
--- PASS: TestAccSSMParameter_disappears (25.13s)
--- PASS: TestAccSSMPatchBaseline_rejectPatchesAction (42.44s)
--- PASS: TestAccSSMMaintenanceWindow_description (69.01s)
--- PASS: TestAccSSMDocument_basic (42.44s)
--- PASS: TestAccSSMMaintenanceWindow_tags (79.75s)
--- PASS: TestAccSSMDocument_automation (70.69s)
--- PASS: TestAccSSMMaintenanceWindowTarget_update (77.05s)
--- PASS: TestAccSSMDocumentDataSource_basic (68.18s)
--- PASS: TestAccSSMPatchGroup_multipleBaselines (35.34s)
--- PASS: TestAccSSMPatchGroup_disappears (31.34s)
--- PASS: TestAccSSMResourceDataSync_basic (66.79s)
--- PASS: TestAccSSMAssociation_rateControl (67.15s)
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (100.08s)
--- PASS: TestAccSSMParameter_overwrite (59.58s)
--- PASS: TestAccSSMPatchGroup_basic (44.66s)
--- PASS: TestAccSSMParameter_noOverwriteWithTags (46.19s)
--- PASS: TestAccSSMParameter_basic (35.26s)
--- PASS: TestAccSSMParameterDataSource_fullPath (34.81s)
--- PASS: TestAccSSMParameter_overwriteWithTags (36.38s)
--- PASS: TestAccSSMDocument_update (76.74s)
--- PASS: TestAccSSMParameter_tags (82.63s)
--- PASS: TestAccSSMAssociation_withComplianceSeverity (77.80s)
--- PASS: TestAccSSMParameter_updateToOverwriteWithTags (74.29s)
--- PASS: TestAccSSMAssociation_withScheduleExpression (78.02s)
--- PASS: TestAccSSMDocument_versionName (69.82s)
--- PASS: TestAccSSMResourceDataSync_update (128.60s)
--- PASS: TestAccSSMDocument_Target_type (63.16s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (94.08s)
--- PASS: TestAccSSMDocument_package (160.85s)
--- PASS: TestAccSSMPatchBaseline_approveUntilDateParam (54.88s)
--- PASS: TestAccSSMDocument_name (62.55s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (104.52s)
--- PASS: TestAccSSMAssociation_withDocumentVersion (41.86s)
--- PASS: TestAccSSMParameter_tier (98.76s)
--- PASS: TestAccSSMPatchBaseline_approvedPatchesNonSec (33.60s)
--- PASS: TestAccSSMAssociation_withTargets (99.16s)
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (65.40s)
--- PASS: TestAccSSMPatchBaseline_sources (55.11s)
--- PASS: TestAccSSMPatchBaseline_disappears (31.85s)
--- PASS: TestAccSSMActivation_disappears (42.94s)
--- PASS: TestAccSSMPatchBaseline_operatingSystem (56.90s)
--- PASS: TestAccSSMActivation_expirationDate (53.27s)
--- PASS: TestAccSSMParameter_overwriteCascade (85.59s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (64.87s)
--- PASS: TestAccSSMAssociation_withParameters (64.68s)
--- PASS: TestAccSSMAssociation_withAssociationName (66.59s)
--- PASS: TestAccSSMActivation_update (80.43s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (143.86s)
--- PASS: TestAccSSMAssociation_basic (149.33s)
--- PASS: TestAccSSMAssociation_disappears (129.95s)
--- PASS: TestAccSSMAssociation_withOutputLocation (151.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	463.625s

@github-actions github-actions bot added service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Feb 9, 2022
@melamity
Copy link
Contributor Author

melamity commented Feb 9, 2022

New acceptance tests:

TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSM -timeout 180m
--- PASS: TestAccSSMMaintenanceWindowTarget_Disappears_window (72.30s)
--- PASS: TestAccSSMMaintenanceWindowTarget_disappears (76.70s)
--- PASS: TestAccSSMMaintenanceWindowTask_emptyNotification (80.26s)
--- PASS: TestAccSSMMaintenanceWindowTask_disappears (81.71s)
--- PASS: TestAccSSMMaintenanceWindowTask_noRole (82.11s)
--- PASS: TestAccSSMMaintenanceWindowTarget_resourceGroup (82.88s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters (86.43s)
--- PASS: TestAccSSMActivation_basic (92.26s)
--- PASS: TestAccSSMMaintenanceWindowTarget_validation (9.42s)
--- PASS: TestAccSSMMaintenanceWindow_duration (100.00s)
--- PASS: TestAccSSMMaintenanceWindowTask_updateForcesNewResource (103.25s)
--- PASS: TestAccSSMParameter_updateType (108.12s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters (108.32s)
--- PASS: TestAccSSMMaintenanceWindowTarget_update (108.88s)
--- PASS: TestAccSSMMaintenanceWindowTask_basic (109.11s)
--- PASS: TestAccSSMMaintenanceWindowTask_description (109.22s)
--- PASS: TestAccSSMMaintenanceWindow_startDate (123.62s)
--- PASS: TestAccSSMDocument_Permission_change (127.98s)
--- PASS: TestAccSSMDocument_disappears (28.03s)
--- PASS: TestAccSSMMaintenanceWindow_scheduleOffset (56.55s)
--- PASS: TestAccSSMMaintenanceWindowTarget_noNameOrDescription (37.59s)
--- PASS: TestAccSSMMaintenanceWindowTarget_basic (36.33s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters (132.26s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters (132.80s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch (134.59s)
--- PASS: TestAccSSMMaintenanceWindow_schedule (58.08s)
--- PASS: TestAccSSMMaintenanceWindow_enabled (63.19s)
--- PASS: TestAccSSMDocument_DocumentFormat_yaml (69.71s)
--- PASS: TestAccSSMMaintenanceWindow_scheduleTimezone (78.23s)
--- PASS: TestAccSSMPatchBaselineDataSource_newBaseline (38.30s)
--- PASS: TestAccSSMPatchBaselineDataSource_existingBaseline (36.11s)
--- PASS: TestAccSSMMaintenanceWindow_endDate (86.72s)
--- PASS: TestAccSSMPatchBaseline_basic (64.02s)
--- PASS: TestAccSSMParameterDataSource_basic (64.01s)
--- PASS: TestAccSSMPatchGroup_disappears (45.75s)
--- PASS: TestAccSSMParametersByPathDataSource_basic (44.01s)
--- PASS: TestAccSSMPatchGroup_multipleBaselines (50.14s)
--- PASS: TestAccSSMParametersByPathDataSource_withRecursion (46.34s)
--- PASS: TestAccSSMPatchGroup_basic (47.34s)
--- PASS: TestAccSSMParameter_updateToOverwriteWithTags (60.35s)
--- PASS: TestAccSSMPatchBaseline_rejectPatchesAction (39.39s)
--- PASS: TestAccSSMDocument_tags (82.24s)
--- PASS: TestAccSSMPatchBaseline_approvedPatchesNonSec (34.67s)
--- PASS: TestAccSSMPatchBaseline_tags (86.10s)
--- PASS: TestAccSSMParameter_tags (92.18s)
--- PASS: TestAccSSMPatchBaseline_disappears (34.89s)
--- PASS: TestAccSSMResourceDataSync_basic (75.59s)
--- PASS: TestAccSSMPatchBaseline_sources (57.08s)
--- PASS: TestAccSSMDocument_session (46.82s)
--- PASS: TestAccSSMParameter_Secure_keyUpdate (82.27s)
--- PASS: TestAccSSMPatchBaseline_approveUntilDateParam (56.17s)
--- PASS: TestAccSSMMaintenanceWindow_disappears (44.66s)
--- PASS: TestAccSSMPatchBaseline_operatingSystem (63.15s)
--- PASS: TestAccSSMParameter_secure (52.67s)
--- PASS: TestAccSSMParameter_fullPath (51.00s)
--- PASS: TestAccSSMParameter_secureWithKey (60.85s)
--- PASS: TestAccSSMResourceDataSync_update (132.13s)
--- PASS: TestAccSSMParameter_overwriteWithTags (47.93s)
--- PASS: TestAccSSMParameter_DataType_awsEC2Image (65.06s)
--- PASS: TestAccSSMDocument_automation (71.21s)
--- PASS: TestAccSSMParameter_disappears (27.24s)
--- PASS: TestAccSSMParameter_noOverwriteWithTags (36.17s)
--- PASS: TestAccSSMMaintenanceWindow_cutoff (73.24s)
--- PASS: TestAccSSMMaintenanceWindow_multipleUpdates (69.63s)
--- PASS: TestAccSSMParameter_basic (36.87s)
--- PASS: TestAccSSMParameter_changeNameForcesNew (79.53s)
--- PASS: TestAccSSMParameter_updateDescription (64.77s)
--- PASS: TestAccSSMParameter_overwrite (65.64s)
--- PASS: TestAccSSMMaintenanceWindow_basic (38.00s)
--- PASS: TestAccSSMMaintenanceWindow_description (60.43s)
--- PASS: TestAccSSMDocument_params (45.86s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (107.06s)
--- PASS: TestAccSSMParameter_overwriteCascade (94.44s)
--- PASS: TestAccSSMDocument_SchemaVersion_1 (64.51s)
--- PASS: TestAccSSMActivation_disappears (40.45s)
--- PASS: TestAccSSMActivation_expirationDate (51.38s)
--- PASS: TestAccSSMAssociation_withDocumentVersion (40.55s)
--- PASS: TestAccSSMParameterDataSource_fullPath (31.37s)
--- PASS: TestAccSSMMaintenanceWindow_tags (84.77s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (75.72s)
--- PASS: TestAccSSMDocument_Permission_batching (40.01s)
--- PASS: TestAccSSMParameter_tier (92.23s)
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (92.26s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (92.37s)
--- PASS: TestAccSSMDocument_Permission_private (42.38s)
--- PASS: TestAccSSMDocument_Permission_public (39.31s)
--- PASS: TestAccSSMAssociation_withTargets (97.55s)
--- PASS: TestAccSSMActivation_update (72.55s)
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (64.25s)
--- PASS: TestAccSSMDocument_name (65.71s)
--- PASS: TestAccSSMDocument_package (146.85s)
--- PASS: TestAccSSMDocument_basic (34.76s)
--- PASS: TestAccSSMDocument_update (66.63s)
--- PASS: TestAccSSMDocument_versionName (64.10s)
--- PASS: TestAccSSMDocument_Target_type (63.18s)
--- PASS: TestAccSSMDocumentDataSource_basic (59.10s)
--- PASS: TestAccSSMAssociation_withParameters (68.79s)
--- PASS: TestAccSSMAssociation_withAssociationName (68.06s)
--- PASS: TestAccSSMAssociation_withComplianceSeverity (67.34s)
--- PASS: TestAccSSMAssociation_withScheduleExpression (60.26s)
--- PASS: TestAccSSMAssociation_rateControl (60.84s)
--- PASS: TestAccSSMAssociation_disappears (150.15s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (144.02s)
--- PASS: TestAccSSMAssociation_basic (167.03s)
--- PASS: TestAccSSMAssociation_withOutputLocation (149.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	418.088s

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Feb 9, 2022
@gdavison gdavison mentioned this pull request Feb 9, 2022
Closed
28 tasks
gdavison
gdavison approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Thanks for picking this up

--- PASS: TestAccSSMDocument_disappears (97.75s)
--- PASS: TestAccSSMDocument_params (99.42s)
--- PASS: TestAccSSMDocument_session (100.30s)
--- PASS: TestAccSSMDocument_Permission_private (100.52s)
--- PASS: TestAccSSMDocument_Permission_public (108.43s)
--- PASS: TestAccSSMDocument_Permission_batching (113.47s)
--- PASS: TestAccSSMDocument_basic (116.00s)
--- PASS: TestAccSSMDocument_automation (119.07s)
--- PASS: TestAccSSMDocument_SchemaVersion_1 (144.38s)
--- PASS: TestAccSSMDocument_Target_type (146.90s)
--- PASS: TestAccSSMDocument_DocumentFormat_yaml (147.27s)
--- PASS: TestAccSSMDocument_name (154.70s)
--- PASS: TestAccSSMDocument_update (154.97s)
--- PASS: TestAccSSMDocument_versionName (154.99s)
--- PASS: TestAccSSMDocument_package (163.10s)
--- PASS: TestAccSSMDocument_tags (166.23s)
--- PASS: TestAccSSMDocument_Permission_change (170.26s)

@gdavison gdavison merged commit 88fcb45 into hashicorp:main Feb 9, 2022
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Feb 9, 2022
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 9, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@melamity @gdavison