Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Backport beta with abp-rust to development. #1469

Merged
merged 23 commits into from
Sep 5, 2019

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Sep 2, 2019

Summary of Changes

This pull request fixes issue #

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

danishjafri88 and others added 23 commits August 9, 2019 17:27
* Release notes for 1.11
@iccub iccub added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Sep 2, 2019
@iccub iccub requested a review from jhreis September 2, 2019 14:00
@jhreis
Copy link
Contributor

jhreis commented Sep 5, 2019

Tested to make sure upgrade and new users. I also did a cherry-pick of ddc2c22 on my own against development and result was same.

Since the rest of these commits are identical, I'm going to treat this merge as a cherry-pick, and squash down the commits, including a bit more details in the commit description.

Nice work. Thanks @iccub

@jhreis jhreis merged commit d09bf1b into development Sep 5, 2019
@jhreis jhreis deleted the backport_abp_rust_beta branch September 5, 2019 02:36
@jhreis jhreis removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants