Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Touch key dialog shows up multiple times on hitting cancel #1349

Closed
jumde opened this issue Aug 8, 2019 · 3 comments · Fixed by #1356
Closed

Touch key dialog shows up multiple times on hitting cancel #1349

jumde opened this issue Aug 8, 2019 · 3 comments · Fixed by #1356

Comments

@jumde
Copy link
Contributor

jumde commented Aug 8, 2019

Description:

If the user clicks cancel on the touch key dialog it should return an error. The dialog pops-up multiple times before showing an error.

Steps to Reproduce

  1. Navigate to demo.yubico.com/u2f
  2. Click register
  3. Hit cancel

Test Plan

Specified here: #1356

Actual result:
The dialog box shows up again

Expected result:
Should return an error

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@jumde
Copy link
Contributor Author

jumde commented Aug 8, 2019

The modal pops-up multiple times if multiple tabs are open. Working on a fix

@srirambv
Copy link
Contributor

srirambv commented Aug 8, 2019

This is happening due to multiple tabs open. If I only have one tab open and hit cancel the dialog is removed

@srirambv srirambv added this to the WebAuthn milestone Aug 8, 2019
jumde added a commit that referenced this issue Aug 8, 2019
jumde added a commit that referenced this issue Aug 9, 2019
jumde added a commit that referenced this issue Aug 9, 2019
jumde added a commit that referenced this issue Aug 9, 2019
jhreis pushed a commit that referenced this issue Aug 9, 2019
@jhreis jhreis modified the milestones: WebAuthn, 1.11.1 Aug 9, 2019
jhreis pushed a commit that referenced this issue Aug 10, 2019
jhreis pushed a commit that referenced this issue Aug 10, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Aug 13, 2019

Verified passed with iPad 5th Gen using 1.11.1 (19.08.12.19)

Verification PASSED on iPhone 6s+ iOS 12.4 using 1.11.1 (19.08.12.20)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants