Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

UI for WebAuthn #1335

Closed
jumde opened this issue Aug 6, 2019 · 8 comments
Closed

UI for WebAuthn #1335

jumde opened this issue Aug 6, 2019 · 8 comments

Comments

@jumde
Copy link
Contributor

jumde commented Aug 6, 2019

Touch Key - This dialog will be displayed when the user should interact with the key.

On Brave Desktop the dialog looks like:

Screen Shot 2019-08-06 at 2 57 29 PM

Allow site to read key data - This dialog will be displayed when the site is requesting access to the security key data.

On Brave Desktop it looks like:

Screen Shot 2019-08-06 at 2 58 28 PM

PIN Required - This dialog will be displayed when the YubiKey is protected by a PIN

On Brave Desktop it looks like:

Screen Shot 2019-08-06 at 3 00 33 PM

@karenkliu
Copy link

karenkliu commented Aug 9, 2019

iOS Designs

User flow:
user flow - log in with yubikey ios

Designs:
1 insert key
2 pin required
3 verifying key
4 touch key

Assets

Insert key:
(animation preview) https://lottiefiles.com/share/zL8bnh
https://assets1.lottiefiles.com/packages/lf20_zL8bnh.json
insertkey.json.zip

Enter PIN:
enter pin.zip

Verifying key:
(animation preview) https://lottiefiles.com/share/PsnbwB
https://assets5.lottiefiles.com/packages/lf20_PsnbwB.json
authenticating.json.zip

Touch the key:
(animation preview) https://lottiefiles.com/share/c2gtfd
https://assets5.lottiefiles.com/packages/lf20_c2gtfd.json
touchthekey.json.zip

Lottie player:
lottie player.zip

@iccub iccub self-assigned this Aug 13, 2019
@jhreis jhreis closed this as completed in f96dad3 Aug 13, 2019
@jhreis jhreis modified the milestones: WebAuthn, 1.11.1 Aug 13, 2019
@kjozwiak
Copy link
Member

@EyanGoldman @anthonypkeane because this includes a lot of new UI/UX components, can someone run through the above and make sure it's working on iPhone X? Hopefully someone has a Yubico key that they can use in the office.

@EyanGoldman
Copy link

Passed on iPhone X

@jumde
Copy link
Contributor Author

jumde commented Aug 13, 2019

The new UIs are missing the site URLs. Will create a PR to add the URLs back.

@iccub
Copy link
Contributor

iccub commented Aug 13, 2019

I removed them because there were not present here :D

@jumde please also replace with Enter your security key PIN with Enter your security PIN

@karenkliu
Copy link

We can add it to the first screen:
1 insert key

Also the second screen with updated string:
2 pin required

@LaurenWags
Copy link
Member

Verified passed with iPad 5th Gen using 1.11.1 (19.08.13.17)

@kjozwiak
Copy link
Member

kjozwiak commented Aug 15, 2019

Verification PASSED on iPhone 6s+ iOS 12.4 using 1.11.1 (19.08.13.17).

IMG_9901
IMG_9899
IMG_9898

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.