Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

UI to avoid double-tap on security keys when unplugged #1153

Closed
jumde opened this issue Jun 13, 2019 · 1 comment · Fixed by #1362
Closed

UI to avoid double-tap on security keys when unplugged #1153

jumde opened this issue Jun 13, 2019 · 1 comment · Fixed by #1362
Assignees
@jamesmudgett
Labels
blocked: needs design Needs design before work can commence bug Epic: WebAuthn QA Pass - iPad QA/Yes release-notes/exclude
Milestone
1.11.3

Comments

@jumde
Copy link
Contributor

jumde commented Jun 13, 2019 •
edited
Loading

Hardware security keys generally take some time to change state where the tap can be accepted, we should think about a pop-over similar to one on desktop to avoid double taps.

Screen Shot 2019-06-13 at 2 43 51 PM

Test Plan:

Specified here: #1362
@tildelowengrimm tildelowengrimm added the blocked: needs design Needs design before work can commence label Jun 13, 2019
@jhreis jhreis removed the UI label Jun 21, 2019
@srirambv srirambv added this to the WebAuthen milestone Jul 26, 2019
@jumde jumde mentioned this issue Aug 9, 2019
Merged
14 tasks
@jhreis jhreis modified the milestones: WebAuthn, 1.11.1 Aug 10, 2019
jhreis pushed a commit that referenced this issue Aug 12, 2019
@jumde @jhreis
Fix #1359, Fix #1153, Fix #1347: Improved modals for security keys (#…
7e5a281 
…1362)
jhreis pushed a commit that referenced this issue Aug 12, 2019
@jumde @jhreis
Fix #1359, Fix #1153, Fix #1347: Improved modals for security keys (#…
78232d5 
…1362)
@LaurenWags
Copy link
Member

Verified passed with iPad 5th Gen using 1.11.1 (19.08.13.17)

@srirambv srirambv mentioned this issue Aug 19, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jamesmudgett jamesmudgett

Labels
blocked: needs design Needs design before work can commence bug Epic: WebAuthn QA Pass - iPad QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.11.3
Development

Successfully merging a pull request may close this issue.

Fix #1359: Improved modals for security keys brave/brave-ios
6 participants
@jamesmudgett @tildelowengrimm @jumde @jhreis @srirambv @LaurenWags