This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 440
Add site url to the touch key modal #1359
Labels
Milestone
Comments
@srirambv - Can we update the description of this issue? I think this issue captures adding the current url to the touch dialog, let me know if i'm missing something |
jumde
changed the title
Cancel on touch key dialog still allows authenticating into the website
Add site url to the touch key modal
Aug 9, 2019
jumde
added a commit
that referenced
this issue
Aug 9, 2019
14 tasks
jumde
added a commit
that referenced
this issue
Aug 9, 2019
jumde
added a commit
that referenced
this issue
Aug 10, 2019
jumde
added a commit
that referenced
this issue
Aug 12, 2019
The URLs from the modals were removed in #1335. Re-opening. |
jumde
added a commit
that referenced
this issue
Aug 13, 2019
14 tasks
jumde
added a commit
that referenced
this issue
Aug 13, 2019
jumde
added a commit
that referenced
this issue
Aug 13, 2019
jumde
added a commit
that referenced
this issue
Aug 14, 2019
jumde
added a commit
that referenced
this issue
Aug 14, 2019
Closed
Moving this into https://github.com/brave/brave-ios/milestone/28 as we won't be fixing it for the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Description:
Cancel on touch key dialog still allows authenticating into the website
Steps to Reproduce
Test Plan
Specified here: #1362
Actual result:
Expected result:
Should include website name in the popup so that easy to understand which popup to use to verify and which ones can be cancelled
Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy
Brave Version:
1.12
Device details:
All
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: