Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add site url to the touch key modal #1359

Closed
srirambv opened this issue Aug 9, 2019 · 6 comments · Fixed by #1362 or #1392
Closed

Add site url to the touch key modal #1359

srirambv opened this issue Aug 9, 2019 · 6 comments · Fixed by #1362 or #1392

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 9, 2019

Description:

Cancel on touch key dialog still allows authenticating into the website

Steps to Reproduce

  1. Visit u2fdemo.hypersecu.com and create an account
  2. Add a security key to the account and logout
  3. Relogin to prompt for security key
  4. Cancel the touch the key dialog that pops up
  5. Touch the key connectors, website authenticates and then brings back the popup

Test Plan

Specified here: #1362

Actual result:
image

Expected result:
Should include website name in the popup so that easy to understand which popup to use to verify and which ones can be cancelled

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.12

Device details:
All

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@jumde
Copy link
Contributor

jumde commented Aug 9, 2019

@srirambv - Can we update the description of this issue? I think this issue captures adding the current url to the touch dialog, let me know if i'm missing something

@jumde jumde changed the title Cancel on touch key dialog still allows authenticating into the website Add site url to the touch key modal Aug 9, 2019
@jumde jumde self-assigned this Aug 9, 2019
@jhreis jhreis modified the milestones: WebAuthn, 1.11.1 Aug 10, 2019
@jumde
Copy link
Contributor

jumde commented Aug 13, 2019

The URLs from the modals were removed in #1335. Re-opening.

@kjozwiak
Copy link
Member

Moving this into https://github.com/brave/brave-ios/milestone/28 as we won't be fixing it for the 1.11.3(originally 1.11.1) as discussed previously.

@srirambv
Copy link
Contributor Author

srirambv commented Sep 6, 2019

Verification passed on iPhone XR with iOS 13.1 beta 2 running 1.12(19.09.06.17)

  • Verified site name is shown in the popup modal
    image
    image

@kjozwiak
Copy link
Member

Verification PASSED on iPad Air 3rd Generation with iOS 13.1 running 1.12 (19.09.10.13):

IMG_0021
IMG_0020
IMG_0018
IMG_0017

@kjozwiak
Copy link
Member

Verification PASSED on iPhone 6s+ using iOS 12.4.1 running 1.12 (19.09.13.06):

IMG_9922
IMG_9921
IMG_9920
IMG_9919

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.