This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #1307: Upgrade adblock stats library to use adblock-rust. #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
added
the
blocked
iccub
changed the title
iccub
changed the title
iccub
commented
Jul 30, 2019
| static let generalAdblockName = "latest" | ||
| static func generalAdblockName(for fileType: FileType) -> String? { | ||
| switch fileType { | ||
| case .dat: return "rs-ABPFilterParserData" |
There was a problem hiding this comment.
Some logic had to be added to handle differences between ios-json and universal-dat files, this includes different endpoints and file names
iccub
commented
Jul 30, 2019
| @@ -0,0 +1,96 @@ | |||
| #ifndef ADBLOCK_RUST_FFI_H | |||
There was a problem hiding this comment.
This file was generated, see https://github.com/brave/adblock-rust-ffi#regenerating-the-c-header
Brandon-T
reviewed
Jul 31, 2019
iccub
removed
the
blocked
Brandon-T
approved these changes
Aug 2, 2019
iccub
added
the
blocked
iccub
force-pushed
the
feature/adblock-rust-migration
branch
from
eb62981 to
64438df
Compare
This file will be now always downloaded from the server if not present on the device.
iccub
force-pushed
the
feature/adblock-rust-migration
branch
from
64438df to
3b387a7
Compare
iccub
removed
the
blocked
jhreis
added
blocked
jhreis
approved these changes
Aug 7, 2019
| switch self { | ||
| case .dat: return "https://adblock-data.s3.brave.com/4/" | ||
| case .json: return "https://adblock-data.s3.brave.com/ios/" | ||
| case .tgz: return "" // Httpse resources are not supported yet. |
There was a problem hiding this comment.
Clarified this, but wanted to say that this does not impact HTTPSE stats, as we currently use a different system for this anyway.
| case .vi: resourceId = "6A0209AC-9869-4FD6-A9DF-039B4200D52C" | ||
| } | ||
|
|
||
| switch fileType { |
There was a problem hiding this comment.
Creative solution to get around this 😄
jumde
approved these changes
Aug 8, 2019
|
lgtm |
jhreis
removed
the
blocked
jhreis
pushed a commit
that referenced
this pull request
Aug 10, 2019
jhreis
added a commit
that referenced
this pull request
Aug 16, 2019
iccub
added a commit
that referenced
this pull request
Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now there is no automation when it comes to updating this library, it needs to be done manually.
Submitter Checklist:
Fix #123: This fixes the shattered coffee cup!(orNo Bug: <message>if no relevant ticket)NSLocalizableString()Test Plan:
Browse through popular websites and see if adblock stats are updating and the app is not crashing.
Play few youtube/twitch videos as well
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement