Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Handle special characters in error description for FIDO/FIDO2 #1360

Closed
jumde opened this issue Aug 9, 2019 · 4 comments · Fixed by #1361
Closed

Handle special characters in error description for FIDO/FIDO2 #1360

jumde opened this issue Aug 9, 2019 · 4 comments · Fixed by #1361

Comments

@jumde
Copy link
Contributor

jumde commented Aug 9, 2019

Description:

Special characters in error descriptions for FIDO/FIDO2 result in javascript exceptions.

Steps to Reproduce

  1. Navigate to demo.yubico.com/u2f
  2. Insert the security key and wait for the timeout interval

Actual result:
After timeout JS exception occurs

Expected result:
Should land on the result page with the correct error

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily

@jhreis
Copy link
Contributor

jhreis commented Aug 9, 2019

Should this be QA'd?

@jumde
Copy link
Contributor Author

jumde commented Aug 9, 2019

Added the test plan for QA

@kjozwiak
Copy link
Member

@jumde I don't think this is working as expected. Whenever I let the Use the security key modal timeout after ~20s, I'm not seeing any errors being displayed nor am I being routed to a results page that displays an error. The modal basically disappears and the page keeps displaying Insert and tap your Yubikey with the animated spinner. Example:

IMG_9864

@LaurenWags
Copy link
Member

LaurenWags commented Aug 13, 2019

Verified passed with iPad 5th Gen using 1.11.1 (19.08.12.19)

  • Verified STR from description
    IMG_4B02E32005DF-1

Verification PASSED on iPhone 6s+ iOS 12.4 using 1.11.1 (19.08.13.17)

  • ensured that once the timeout occurs on both the Register & Authenticate modals under demo.yubico.com/u2f, an error message is correctly displayed and the page finishes loading.

IMG_9867

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.